One more E_STRICT warning tweak for http://192.168.0.64/wiki/index.php?action=ajax...

* Strict Standards: Undefined index: rs in includes/AjaxDispatcher.php on line 38

Q: Should / could the AjaxDispatcher constructor maybe be using the $wgRequest global instead of accessing $_POST and $_GET directly?

diff --git a/includes/AjaxDispatcher.php b/includes/AjaxDispatcher.php
index 89062f8..1f41a83 100644 (file)
--- a/includes/AjaxDispatcher.php
+++ b/includes/AjaxDispatcher.php
@@ -28,14 +28,14 @@ class AjaxDispatcher {
                }
 
                if ($this->mode == "get") {
-                       $this->func_name = $_GET["rs"];
+                       $this->func_name = isset( $_GET["rs"] ) ? $_GET["rs"] : '';
                        if (! empty($_GET["rsargs"])) {
                                $this->args = $_GET["rsargs"];
                        } else {
                                $this->args = array();
                        }
                } else {
-                       $this->func_name = $_POST["rs"];
+                       $this->func_name = isset( $_POST["rs"] ) ? $_POST["rs"] : '';
                        if (! empty($_POST["rsargs"])) {
                                $this->args = $_POST["rsargs"];
                        } else {