* (bug 2568) Fixed a logic error in the Special:Statistics code which caused

  the displayed percentage of admins to be totally off.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index cc378d1..3c050f4 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -395,7 +395,8 @@ Various bugfixes, small features, and a few experimental things:
 * upgrade1_5.php uses insert ignore, allows to skip image info initialization
 * Fix namespaces in category list.
 * Add rebuildImages.php to update image metadata fields
-
+* (bug 2568) Fixed a logic error in the Special:Statistics code which caused
+  the displayed percentage of admins to be totally off.
 
 === Caveats ===
 

diff --git a/includes/SpecialStatistics.php b/includes/SpecialStatistics.php
index 8706e8b..d9acfd0 100644 (file)
--- a/includes/SpecialStatistics.php
+++ b/includes/SpecialStatistics.php
@@ -75,7 +75,7 @@ function wfSpecialStatistics() {
                        $wgLang->formatNum( $admins ),
                        '[[' . wfMsg( 'administrators' ) . ']]',
                        // should logically be after #admins, danm backwards compatability!
-                       $wgLang->formatNum( round( $admins / $total * 100, 2 ) )
+                       $wgLang->formatNum( sprintf( '%.2f', $admins / $users * 100 ) )
                );
                
                $wgOut->addWikiText( $text );