From fd84e8580fffd2a65b109364731fba678ec7c694 Mon Sep 17 00:00:00 2001 From: addshore Date: Tue, 21 Mar 2017 22:37:30 +0000 Subject: [PATCH] Cast to bool in Database::update The interface is documented as returning a bool, so stick to that interface. Bug: T160956 Change-Id: I725651e1d66fdd6c52ef82e93fd9e3c837edb022 --- includes/libs/rdbms/database/Database.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/libs/rdbms/database/Database.php b/includes/libs/rdbms/database/Database.php index 90e60a322e..92adaf9ce6 100644 --- a/includes/libs/rdbms/database/Database.php +++ b/includes/libs/rdbms/database/Database.php @@ -1542,7 +1542,7 @@ abstract class Database implements IDatabase, IMaintainableDatabase, LoggerAware $sql .= " WHERE " . $this->makeList( $conds, self::LIST_AND ); } - return $this->query( $sql, $fname ); + return (bool)$this->query( $sql, $fname ); } public function makeList( $a, $mode = self::LIST_COMMA ) { -- 2.20.1