From eaeb1d9b38032e8574627588a1018f7ae2b592f4 Mon Sep 17 00:00:00 2001
From: Brion Vibber <brion@users.mediawiki.org>
Date: Mon, 22 Aug 2005 06:25:13 +0000
Subject: [PATCH] This line has been broken at least twice in the last year.
 Add a comment to esplain why that's not wise.

---
 includes/PageHistory.php | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/includes/PageHistory.php b/includes/PageHistory.php
index a774248dc4..8280d26ffa 100644
--- a/includes/PageHistory.php
+++ b/includes/PageHistory.php
@@ -186,7 +186,20 @@ class PageHistory {
 		$s = wfMsgWikiHtml( 'histlegend' );
 		$s .= '<form action="' . $wgTitle->escapeLocalURL( '-' ) . '" method="get">';
 		$prefixedkey = htmlspecialchars($wgTitle->getPrefixedDbKey());
+		
+		// The following line is SUPPOSED to have double-quotes around the
+		// $prefixedkey variable, because htmlspecialchars() doesn't escape
+		// single-quotes.
+		//
+		// On at least two occasions people have changed it to single-quotes,
+		// which creates invalid HTML and incorrect display of the resulting
+		// link.
+		//
+		// Please do not break this a third time. Thank you for your kind
+		// consideration and cooperation.
+		//
 		$s .= "<input type='hidden' name='title' value=\"{$prefixedkey}\" />\n";
+		
 		$s .= $this->submitButton();
 		$s .= '<ul id="pagehistory">' . "\n";
 		return $s;
-- 
2.20.1