From bb6f68137406df747f41c02f5570ff4da31e1216 Mon Sep 17 00:00:00 2001 From: Tim Starling Date: Wed, 17 Dec 2008 07:42:46 +0000 Subject: [PATCH] Is this needed? Probably not, but it doesn't hurt. The connection is only used for reading, so the commitMasterChanges() is technically unnecessary but harmless. Without closeAll(), the connection will be held open until the script terminates, but that's probably pretty soon in this case. --- maintenance/FiveUpgrade.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/maintenance/FiveUpgrade.inc b/maintenance/FiveUpgrade.inc index 3d917e72dd..4fb34308a4 100644 --- a/maintenance/FiveUpgrade.inc +++ b/maintenance/FiveUpgrade.inc @@ -77,8 +77,7 @@ class FiveUpgrade { } /** - * Close out the connections when we're done... - * Is this needed? + * Commit transactions and close the connections when we're done... */ function close() { foreach( $this->loadBalancers as $lb ) { -- 2.20.1