From ac9bd01ecb765b6dc1f5e1ac139f572409255a29 Mon Sep 17 00:00:00 2001 From: Platonides Date: Tue, 7 Dec 2010 20:40:15 +0000 Subject: [PATCH] Remove the $wgCaches[CACHE_DB] = false; line added in r74552. It produces an strange failure when going out of ParserTest::setUp() scope. (eg. $parserMemc becoming back false instead of a FakeMemcached, related to using a reference in $wgMemc = &wfGetMainCache() ) Can be checked when running phpunit.php includes/ParserOptionsTest.php See https://bugzilla.wikimedia.org/show_bug.cgi?id=26244#c4 No errors found in sqlite without it. --- maintenance/tests/phpunit/phpunit.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/maintenance/tests/phpunit/phpunit.php b/maintenance/tests/phpunit/phpunit.php index 744f3d0b79..94d4ebd2d6 100755 --- a/maintenance/tests/phpunit/phpunit.php +++ b/maintenance/tests/phpunit/phpunit.php @@ -20,9 +20,6 @@ require_once( "$IP/maintenance/commandLine.inc" ); // Assume UTC for testing purposes $wgLocaltimezone = 'UTC'; -// To prevent tests from failing with SQLite, we need to turn database caching off -$wgCaches[CACHE_DB] = false; - require_once( 'PHPUnit/Runner/Version.php' ); if( version_compare( PHPUnit_Runner_Version::id(), '3.5.0', '>=' ) ) { # PHPUnit 3.5.0 introduced a nice autoloader based on class name -- 2.20.1