From 7bcf8450a1d488d909185a5cf4d3eff6058f2092 Mon Sep 17 00:00:00 2001
From: Raimond Spekking <raymond@users.mediawiki.org>
Date: Mon, 15 Dec 2008 22:26:50 +0000
Subject: [PATCH] Add a descriptive message for rows/cols of
 Special:Preferences#Editing

---
 includes/specials/SpecialPreferences.php | 18 +++++++++---------
 languages/messages/MessagesEn.php        |  1 +
 maintenance/language/messages.inc        |  1 +
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/includes/specials/SpecialPreferences.php b/includes/specials/SpecialPreferences.php
index ae8d8b4cc6..4859d00d27 100644
--- a/includes/specials/SpecialPreferences.php
+++ b/includes/specials/SpecialPreferences.php
@@ -934,12 +934,11 @@ class PreferencesForm {
 		# Editing
 		#
 		global $wgLivePreview;
-		$wgOut->addHTML( '<fieldset><legend>' . wfMsg( 'textboxsize' ) . '</legend>
-			<div>' .
-				Xml::inputLabel( wfMsg( 'rows' ), 'wpRows', 'wpRows', 3, $this->mRows ) .
-				' ' .
-				Xml::inputLabel( wfMsg( 'columns' ), 'wpCols', 'wpCols', 3, $this->mCols ) .
-			"</div>" .
+		$wgOut->addHTML(
+			Xml::fieldset( wfMsg( 'textboxsize' ) ) .
+			wfMsgHTML( 'prefs-edit-boxsize' ) . ' ' .
+			Xml::inputLabel( wfMsg( 'rows' ), 'wpRows', 'wpRows', 3, $this->mRows ) . ' ' .
+			Xml::inputLabel( wfMsg( 'columns' ), 'wpCols', 'wpCols', 3, $this->mCols ) .
 			$this->getToggles( array(
 				'editsection',
 				'editsectiononrightclick',
@@ -953,9 +952,10 @@ class PreferencesForm {
 				'externaldiff',
 				$wgLivePreview ? 'uselivepreview' : false,
 				'forceeditsummary',
-			) ) );
-		
-		$wgOut->addHTML( '</fieldset>' );
+			) )
+		);
+
+		$wgOut->addHTML( Xml::closeElement( 'fieldset' ) );
 
 		# Recent changes
 		global $wgRCMaxAge;
diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php
index 405db6a066..bfda7d19c7 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -1551,6 +1551,7 @@ please see math/README to configure.',
 'saveprefs'                 => 'Save',
 'resetprefs'                => 'Clear unsaved changes',
 'textboxsize'               => 'Editing',
+'prefs-edit-boxsize'        => 'Size of the edit window.',
 'rows'                      => 'Rows:',
 'columns'                   => 'Columns:',
 'searchresultshead'         => 'Search',
diff --git a/maintenance/language/messages.inc b/maintenance/language/messages.inc
index 9cec2e65ec..a55041bcc4 100644
--- a/maintenance/language/messages.inc
+++ b/maintenance/language/messages.inc
@@ -872,6 +872,7 @@ $wgMessageStructure = array(
 		'saveprefs',
 		'resetprefs',
 		'textboxsize',
+		'prefs-edit-boxsize',
 		'rows',
 		'columns',
 		'searchresultshead',
-- 
2.20.1