From 52e546640c5c0c0e817ae1fc5451a934b2c34de9 Mon Sep 17 00:00:00 2001 From: Chad Horohoe Date: Wed, 6 Nov 2013 15:31:25 -0800 Subject: [PATCH] Work around HHVM bug with stdin/stdout in proc_open() Bug: 56597 Change-Id: I06122d82fce4567be110ca25010c244dd9269c57 --- includes/GlobalFunctions.php | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php index 93a2b029f0..1eb5c3e62a 100644 --- a/includes/GlobalFunctions.php +++ b/includes/GlobalFunctions.php @@ -2855,6 +2855,15 @@ function wfShellExec( $cmd, &$retval = null, $environ = array(), if ( $useLogPipe ) { $desc[3] = array( 'pipe', 'w' ); } + + # TODO/FIXME: This is a bad hack to workaround an HHVM bug that prevents + # proc_open() from opening stdin/stdout, so use /dev/null *for now* + # See bug 56597 / https://github.com/facebook/hhvm/issues/1247 for more info + if ( wfIsHHVM() ) { + $desc[0] = array( 'file', '/dev/null', 'r' ); + $desc[2] = array( 'file', '/dev/null', 'w' ); + } + $pipes = null; $proc = proc_open( $cmd, $desc, $pipes ); if ( !$proc ) { -- 2.20.1