From 2ce8768495da33228653b28343a5365afa4282e0 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Wed, 17 Jun 2015 22:12:47 +0200 Subject: [PATCH] Avoid assignment in return in TemplateParser.php Hard to read and may misread as boolean return Change-Id: If6bfdbed7e647dde51db62ae6901874a83682d9e --- includes/TemplateParser.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/TemplateParser.php b/includes/TemplateParser.php index 3de70fa2a2..d53d593f77 100644 --- a/includes/TemplateParser.php +++ b/includes/TemplateParser.php @@ -130,7 +130,8 @@ class TemplateParser { if ( !is_callable( $renderer ) ) { throw new RuntimeException( "Requested template, {$templateName}, is not callable" ); } - return $this->renderers[$templateName] = $renderer; + $this->renderers[$templateName] = $renderer; + return $renderer; } /** -- 2.20.1