From 2b66dc047f57f184cd1486680f82ce92c759c527 Mon Sep 17 00:00:00 2001 From: Kevin Israel Date: Wed, 26 Aug 2015 00:38:54 -0400 Subject: [PATCH] Fix typo in UploadFromUrlJob::initializeSessionData() Behavior would change under PHP7, though neither the current behavior nor the new behavior seem correct. Did not test, as the feature has been broken anyway since r81612 / e942dc69fcc6. https://github.com/facebook/hhvm/issues/5523#issuecomment-133132721 Change-Id: Iac1177fee05b6c721abe54b6a96c1652445a5c90 --- includes/jobqueue/jobs/UploadFromUrlJob.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/jobqueue/jobs/UploadFromUrlJob.php b/includes/jobqueue/jobs/UploadFromUrlJob.php index a15d51e835..ade481068d 100644 --- a/includes/jobqueue/jobs/UploadFromUrlJob.php +++ b/includes/jobqueue/jobs/UploadFromUrlJob.php @@ -166,11 +166,11 @@ class UploadFromUrlJob extends Job { } /** - * Initialize the session data. Sets the intial result to queued. + * Initialize the session data. Sets the initial result to queued. */ public function initializeSessionData() { $session =& self::getSessionData( $this->params['sessionKey'] ); - $$session['result'] = 'Queued'; + $session['result'] = 'Queued'; } /** -- 2.20.1