From 22b112aedab8c248f9a2a92a2f910102578cb8ec Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Tue, 21 Feb 2017 18:51:45 -0800 Subject: [PATCH] resourceloader: Fix testMakeModuleResponseError() failure on Travis > 1) ResourceLoaderTest::testMakeModuleResponseError > Failed asserting that '[e08c982d974548127cb5d7ce] Fatal exception of type Exception' > matches PCRE pattern "/Ferry not found/". > .../ResourceLoaderTest.php:519 This happened on Travis CI, because ResourceLoader::formatException() behaves differently based on $wgShowExceptionDetails. Which is enabled in Vagrant and Jenkins, but disabled by default (and thus in Travis CI builds). Bug: T75176 Change-Id: If15dd03213703b7b6ff899cad5e5569e2515b378 --- tests/phpunit/includes/resourceloader/ResourceLoaderTest.php | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderTest.php index cde1e5abb3..e0a82d06af 100644 --- a/tests/phpunit/includes/resourceloader/ResourceLoaderTest.php +++ b/tests/phpunit/includes/resourceloader/ResourceLoaderTest.php @@ -18,6 +18,7 @@ class ResourceLoaderTest extends ResourceLoaderTestCase { // to avoid notices during testMakeModuleResponse for missing // wgResourceLoaderLESSVars keys in extension hooks. 'wgHooks' => [], + 'wgShowExceptionDetails' => true, ] ); } -- 2.20.1