From 22697961bee6c84bf97579f78645d2e9725a9d46 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Thu, 11 Dec 2008 18:44:51 +0000 Subject: [PATCH] Reverting r44454 "(bug 14843) IRC should flag redirects with "R" like it does with bots, etc." This doesn't work as intended; when editing existing articles, this'll pull the *previous* redirection state of the article, rather than the current state, so it's wrong whenever a page is changed into, or away from, being a redirect. --- RELEASE-NOTES | 2 -- includes/RecentChange.php | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index c006eba862..e406fb142e 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -218,8 +218,6 @@ The following extensions are migrated into MediaWiki 1.14: * Added complimentary function for addHandler() called removeHandler() for removing events * Improved security of file uploads for IE clients, using a reverse-engineered algorithm very similar to IE's content detection algorithm. -* (bug 14843) IRC output for RecentChanges now contains an "R" flag if the page - is a redirect. === Bug fixes in 1.14 === diff --git a/includes/RecentChange.php b/includes/RecentChange.php index 06d6092825..92b9aac4b9 100644 --- a/includes/RecentChange.php +++ b/includes/RecentChange.php @@ -645,8 +645,7 @@ class RecentChange $flag = $rc_log_action; } else { $comment = self::cleanupForIRC( $rc_comment ); - $flag = ($rc_new ? "N" : "") . ($rc_minor ? "M" : "") . ($rc_bot ? "B" : "") - . ($this->getTitle()->isRedirect() ? "R" : ""); + $flag = ($rc_new ? "N" : "") . ($rc_minor ? "M" : "") . ($rc_bot ? "B" : ""); } if ( $wgRC2UDPInterwikiPrefix === true ) { -- 2.20.1