From 16c81325edd2a0ed3f3c387079a12f70ab2b6619 Mon Sep 17 00:00:00 2001 From: Matthew Flaschen Date: Thu, 30 Jul 2015 21:27:07 -0400 Subject: [PATCH] array_shift returns null on empty array, not false Change-Id: I690f9dd0de11ff60f9cba9f401c6e456e7ba8bd6 --- includes/objectcache/RedisBagOStuff.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/objectcache/RedisBagOStuff.php b/includes/objectcache/RedisBagOStuff.php index 7e506f0d7a..11dd660e0d 100644 --- a/includes/objectcache/RedisBagOStuff.php +++ b/includes/objectcache/RedisBagOStuff.php @@ -372,7 +372,7 @@ class RedisBagOStuff extends BagOStuff { } } - while ( ( $tag = array_shift( $candidates ) ) !== false ) { + while ( ( $tag = array_shift( $candidates ) ) !== null ) { $server = $this->serverTagMap[$tag]; $conn = $this->redisPool->getConnection( $server ); if ( !$conn ) { -- 2.20.1