From 15c7dbed0807fb067619d292fbff1d727a7e9e92 Mon Sep 17 00:00:00 2001 From: Platonides Date: Tue, 25 Jan 2011 23:37:11 +0000 Subject: [PATCH] generateUpgradeKey() could produce NULL return, which means a fatal error when Call to a member function isOk() in includes/installer/WebInstallerPage.php on line 1039 --- includes/installer/Installer.php | 1 + 1 file changed, 1 insertion(+) diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php index 507ba2ebc6..9206b36cba 100644 --- a/includes/installer/Installer.php +++ b/includes/installer/Installer.php @@ -1352,6 +1352,7 @@ abstract class Installer { if ( strval( $this->getVar( 'wgUpgradeKey' ) ) === '' ) { return $this->generateSecret( 'wgUpgradeKey', 16 ); } + return Status::newGood(); } /** -- 2.20.1