From 1039b7c7b6027795be9f51b8e69653d6c35ffc43 Mon Sep 17 00:00:00 2001 From: jeroendedauw Date: Sat, 22 Dec 2012 01:01:27 +0100 Subject: [PATCH] Simplify Xml::encodeJsCall Change-Id: Idf2838a1b32170ca6336eb4a67f16cd3335218f9 --- includes/Xml.php | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/includes/Xml.php b/includes/Xml.php index 67f365848d..d5e9189ef1 100644 --- a/includes/Xml.php +++ b/includes/Xml.php @@ -682,22 +682,11 @@ class Xml { * @return string */ public static function encodeJsCall( $name, $args ) { - $s = "$name("; - $first = true; - - foreach ( $args as $arg ) { - if ( $first ) { - $first = false; - } else { - $s .= ', '; - } - - $s .= Xml::encodeJsVar( $arg ); + foreach ( $args as &$arg ) { + $arg = Xml::encodeJsVar( $arg ); } - $s .= ");\n"; - - return $s; + return "$name(" . implode( ', ', $args ) . ");\n"; } /** -- 2.20.1