From 012b09bc969c18472454c3332034e586a979096a Mon Sep 17 00:00:00 2001
From: "Amir E. Aharoni" <amir.aharoni@mail.huji.ac.il>
Date: Tue, 26 Nov 2013 15:42:34 +0200
Subject: [PATCH] Cleanup variable use in getLanguages

Change-Id: Ie480f701aa2b117fd73f3f1e2cca1cc9994b2605
---
 includes/SkinTemplate.php | 30 ++++++++++++++++++++----------
 1 file changed, 20 insertions(+), 10 deletions(-)

diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index 7647e51895..dde3f3725d 100644
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -134,15 +134,14 @@ class SkinTemplate extends Skin {
 			return array();
 		}
 
-		$out = $this->getOutput();
 		$userLang = $this->getLanguage();
-
 		$languageLinks = array();
 
-		foreach ( $out->getLanguageLinks() as $languageLinkText ) {
+		foreach ( $this->getOutput()->getLanguageLinks() as $languageLinkText ) {
 			$languageLinkParts = explode( ':', $languageLinkText, 2 );
 			$class = 'interlanguage-link interwiki-' . $languageLinkParts[0];
 			unset( $languageLinkParts );
+
 			$languageLinkTitle = Title::newFromText( $languageLinkText );
 			if ( $languageLinkTitle ) {
 				$ilInterwikiCode = $languageLinkTitle->getInterwiki();
@@ -156,22 +155,33 @@ class SkinTemplate extends Skin {
 
 				// CLDR extension or similar is required to localize the language name;
 				// otherwise we'll end up with the autonym again.
-				$ilLangLocalName = Language::fetchLanguageName( $ilInterwikiCode, $userLang->getCode() );
+				$ilLangLocalName = Language::fetchLanguageName(
+					$ilInterwikiCode,
+					$userLang->getCode()
+				);
 
-				if ( $languageLinkTitle->getText() === '' ) {
-					$ilTitle = wfMessage( 'interlanguage-link-title-langonly', $ilLangLocalName )->text();
+				$languageLinkTitleText = $languageLinkTitle->getText();
+				if ( $languageLinkTitleText === '' ) {
+					$ilTitle = wfMessage(
+						'interlanguage-link-title-langonly',
+						$ilLangLocalName
+					)->text();
 				} else {
-					$ilTitle = wfMessage( 'interlanguage-link-title', $languageLinkTitle->getText(),
-						$ilLangLocalName )->text();
+					$ilTitle = wfMessage(
+						'interlanguage-link-title',
+						$languageLinkTitleText,
+						$ilLangLocalName
+					)->text();
 				}
 
+				$ilInterwikiCodeBCP47 = wfBCP47( $ilInterwikiCode );
 				$languageLinks[] = array(
 					'href' => $languageLinkTitle->getFullURL(),
 					'text' => $ilLangName,
 					'title' => $ilTitle,
 					'class' => $class,
-					'lang' => wfBCP47( $ilInterwikiCode ),
-					'hreflang' => wfBCP47( $ilInterwikiCode ),
+					'lang' => $ilInterwikiCodeBCP47,
+					'hreflang' => $ilInterwikiCodeBCP47,
 				);
 			}
 		}
-- 
2.20.1