From: Florian <florian.schmidt.stargatewissen@gmail.com>
Date: Wed, 16 Sep 2015 15:50:56 +0000 (+0200)
Subject: Extend Title check in Skin for titles without associated titles
X-Git-Tag: 1.31.0-rc.0~9982^2
X-Git-Url: http://git.cyclocoop.org/%24href?a=commitdiff_plain;h=8bc0218c75eb6470f4610a2910b2414ab552f43f;p=lhc%2Fweb%2Fwiklou.git

Extend Title check in Skin for titles without associated titles

Like talk or the subject title (for a talk title). This prevents Skin.php
from trying to get the talk title of a title in a namespace that can't hold
any.

Follow up:
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/80409

Bug: T110878
Change-Id: I3c803d784f931a21b47065590e567f8bb111aa2a
---

diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php
index 53af3e7da9..0b19c33f0f 100644
--- a/includes/skins/Skin.php
+++ b/includes/skins/Skin.php
@@ -238,8 +238,8 @@ abstract class Skin extends ContextSource {
 			$titles[] = $user->getTalkPage();
 		}
 
-		// Other tab link
-		if ( $title->isSpecialPage() ) {
+		// Check, if the page can hold some kind of content, otherwise do nothing
+		if ( !$title->canExist() ) {
 			// nothing
 		} elseif ( $title->isTalkPage() ) {
 			$titles[] = $title->getSubjectPage();