From: aude <aude.wiki@gmail.com>
Date: Thu, 6 Mar 2014 23:37:42 +0000 (+0100)
Subject: Add visibility in PoolCounter classes
X-Git-Tag: 1.31.0-rc.0~16706^2
X-Git-Url: http://git.cyclocoop.org/%24href?a=commitdiff_plain;h=81d5a7833d0442a9160ea689e578c6134df5dcd0;p=lhc%2Fweb%2Fwiklou.git

Add visibility in PoolCounter classes

Change-Id: Ieb8916235fa37247aa11a4d1fad59d929997d0e6
---

diff --git a/includes/PoolCounter.php b/includes/PoolCounter.php
index 7acabfd508..85c4c79a34 100644
--- a/includes/PoolCounter.php
+++ b/includes/PoolCounter.php
@@ -182,7 +182,7 @@ abstract class PoolCounterWork {
 	 * Do something with the error, like showing it to the user.
 	 * @return bool
 	 */
-	function error( $status ) {
+	public function error( $status ) {
 		return false;
 	}
 
@@ -192,7 +192,7 @@ abstract class PoolCounterWork {
 	 * @param $status Status
 	 * @return void
 	 */
-	function logError( $status ) {
+	public function logError( $status ) {
 		$key = $this->poolCounter->getKey();
 
 		wfDebugLog( 'poolcounter', "Pool key '$key': "
@@ -323,14 +323,14 @@ class PoolCounterWorkViaCallback extends PoolCounterWork {
 		return false;
 	}
 
-	function fallback() {
+	public function fallback() {
 		if ( $this->fallback ) {
 			return call_user_func_array( $this->fallback, array() );
 		}
 		return false;
 	}
 
-	function error( $status ) {
+	public function error( $status ) {
 		if ( $this->error ) {
 			return call_user_func_array( $this->error, array( $status ) );
 		}
diff --git a/includes/WikiPage.php b/includes/WikiPage.php
index 3de0475acb..cb730ce165 100644
--- a/includes/WikiPage.php
+++ b/includes/WikiPage.php
@@ -1568,7 +1568,7 @@ class WikiPage implements Page, IDBAccessObject {
 	 * @param $flags Int
 	 * @return Int updated $flags
 	 */
-	function checkFlags( $flags ) {
+	public function checkFlags( $flags ) {
 		if ( !( $flags & EDIT_NEW ) && !( $flags & EDIT_UPDATE ) ) {
 			if ( $this->exists() ) {
 				$flags |= EDIT_UPDATE;
@@ -3508,7 +3508,7 @@ class PoolWorkArticleView extends PoolCounterWork {
 	 * @param $parserOptions parserOptions to use for the parse operation
 	 * @param $content Content|String: content to parse or null to load it; may also be given as a wikitext string, for BC
 	 */
-	function __construct( Page $page, ParserOptions $parserOptions, $revid, $useParserCache, $content = null ) {
+	public function __construct( Page $page, ParserOptions $parserOptions, $revid, $useParserCache, $content = null ) {
 		if ( is_string( $content ) ) { // BC: old style call
 			$modelId = $page->getRevision()->getContentModel();
 			$format = $page->getRevision()->getContentFormat();
@@ -3554,7 +3554,7 @@ class PoolWorkArticleView extends PoolCounterWork {
 	/**
 	 * @return bool
 	 */
-	function doWork() {
+	public function doWork() {
 		global $wgUseFileCache;
 
 		// @todo several of the methods called on $this->page are not declared in Page, but present
@@ -3617,7 +3617,7 @@ class PoolWorkArticleView extends PoolCounterWork {
 	/**
 	 * @return bool
 	 */
-	function getCachedWork() {
+	public function getCachedWork() {
 		$this->parserOutput = ParserCache::singleton()->get( $this->page, $this->parserOptions );
 
 		if ( $this->parserOutput === false ) {
@@ -3632,7 +3632,7 @@ class PoolWorkArticleView extends PoolCounterWork {
 	/**
 	 * @return bool
 	 */
-	function fallback() {
+	public function fallback() {
 		$this->parserOutput = ParserCache::singleton()->getDirty( $this->page, $this->parserOptions );
 
 		if ( $this->parserOutput === false ) {
@@ -3651,7 +3651,7 @@ class PoolWorkArticleView extends PoolCounterWork {
 	 * @param $status Status
 	 * @return bool
 	 */
-	function error( $status ) {
+	public function error( $status ) {
 		$this->error = $status;
 		return false;
 	}