From: Sam Reed <reedy@users.mediawiki.org>
Date: Thu, 30 Dec 2010 17:41:19 +0000 (+0000)
Subject: Fix private class member variable access
X-Git-Tag: 1.31.0-rc.0~32973
X-Git-Url: http://git.cyclocoop.org/%24href?a=commitdiff_plain;h=48ebf5bbb5a93958a82cb7189bd013ba64327724;p=lhc%2Fweb%2Fwiklou.git

Fix private class member variable access

Some method documentation
---

diff --git a/includes/db/DatabaseOracle.php b/includes/db/DatabaseOracle.php
index 63e68f04f5..8893e2ef21 100644
--- a/includes/db/DatabaseOracle.php
+++ b/includes/db/DatabaseOracle.php
@@ -808,7 +808,7 @@ class DatabaseOracle extends DatabaseBase {
 	# Returns the size of a text field, or -1 for "unlimited"
 	function textFieldSize( $table, $field ) {
 		$fieldInfoData = $this->fieldInfo( $table, $field);
-		if ( $fieldInfoData->type == 'varchar' ) {
+		if ( $fieldInfoData->type() == 'varchar' ) {
 			$size = $row->size - 4;
 		} else {
 			$size = $row->size;
@@ -928,6 +928,7 @@ class DatabaseOracle extends DatabaseBase {
 	 *
 	 * @param $table Array
 	 * @param $field String
+	 * @return ORAField
 	 */
 	private function fieldInfoMulti( $table, $field ) {
 		$field = strtoupper( $field );
@@ -975,6 +976,12 @@ class DatabaseOracle extends DatabaseBase {
 		return $fieldInfoTemp;
 	}
 
+	/**
+	 * @throws DBUnexpectedError
+	 * @param  $table
+	 * @param  $field
+	 * @return ORAField
+	 */
 	function fieldInfo( $table, $field ) {
 		if ( is_array( $table ) ) {
 			throw new DBUnexpectedError( $this, 'DatabaseOracle::fieldInfo called with table array!' );