From: Trevor Parscal Date: Mon, 20 Sep 2010 19:04:16 +0000 (+0000) Subject: Fixed bug caused by unset( $this->mSkin ) in User::setOption which was removing the... X-Git-Tag: 1.31.0-rc.0~34858 X-Git-Url: http://git.cyclocoop.org/%24href?a=commitdiff_plain;h=0df196f2c6521b12f91c8df4fccfe77e6355299b;p=lhc%2Fweb%2Fwiklou.git Fixed bug caused by unset( $this->mSkin ) in User::setOption which was removing the member, not just setting it to null, which would cause errors when later on checking if ( ! $this->mSkin ) such as in User::getSkin. By using $this->mSkin = null instead, the same effect of showing the new skin preference immediately on change in Special:Preferences without causing errors. --- diff --git a/includes/User.php b/includes/User.php index c06abffe41..3d4d8765a1 100644 --- a/includes/User.php +++ b/includes/User.php @@ -2006,7 +2006,7 @@ class User { if ( $oname == 'skin' ) { # Clear cached skin, so the new one displays immediately in Special:Preferences - unset( $this->mSkin ); + $this->mSkin = null; } // Explicitly NULL values should refer to defaults