From edc11af72546b923da0fc868eb906e83dfd14058 Mon Sep 17 00:00:00 2001 From: Alangi Derick Date: Tue, 27 Nov 2018 16:47:07 +0100 Subject: [PATCH] Fix global variable name typo in LocalIdLookupTest.php Per @Thiemo and @Anomie's comments on the patch, droppping dependency of the test value to not be a global, using "dummy" in this case. Bug: T210512 Change-Id: I26aff5fe4782837a8f52a102ae1bdbac49b748bc --- tests/phpunit/includes/user/LocalIdLookupTest.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/phpunit/includes/user/LocalIdLookupTest.php b/tests/phpunit/includes/user/LocalIdLookupTest.php index 6ce01ca885..58441f095f 100644 --- a/tests/phpunit/includes/user/LocalIdLookupTest.php +++ b/tests/phpunit/includes/user/LocalIdLookupTest.php @@ -124,9 +124,8 @@ class LocalIdLookupTest extends MediaWikiTestCase { * @param bool $localDBSet $wgLocalDatabases contains the shared DB */ public function testIsAttachedShared( $sharedDB, $sharedTable, $localDBSet ) { - global $wgDBName; $this->setMwGlobals( [ - 'wgSharedDB' => $sharedDB ? $wgDBName : null, + 'wgSharedDB' => $sharedDB ? "dummy" : null, 'wgSharedTables' => $sharedTable ? [ 'user' ] : [], 'wgLocalDatabases' => $localDBSet ? [ 'shared' ] : [], ] ); -- 2.20.1