From ad86d3287535106838577152a6c3d1470fa0611f Mon Sep 17 00:00:00 2001
From: Alexandre Emsenhuber <mediawiki@emsenhuber.ch>
Date: Sat, 24 May 2014 07:45:33 +0200
Subject: [PATCH] Don't use isset() to check for null

Fixes in includes/specials

Change-Id: I6c382aeaa92372bc11220694c479006e3c658362
---
 includes/specials/SpecialAllpages.php            | 2 +-
 includes/specials/SpecialChangePassword.php      | 2 +-
 includes/specials/SpecialFileDuplicateSearch.php | 2 +-
 includes/specials/SpecialLinkSearch.php          | 4 ++--
 includes/specials/SpecialPrefixindex.php         | 7 +++----
 includes/specials/SpecialWhatlinkshere.php       | 2 +-
 6 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/includes/specials/SpecialAllpages.php b/includes/specials/SpecialAllpages.php
index ad92298cf5..0490d82b6d 100644
--- a/includes/specials/SpecialAllpages.php
+++ b/includes/specials/SpecialAllpages.php
@@ -296,7 +296,7 @@ class SpecialAllpages extends IncludableSpecialPage {
 		$bottomLinks = array();
 
 		# Do we put a previous link ?
-		if ( isset( $prevTitle ) && $pt = $prevTitle->getText() ) {
+		if ( $prevTitle && $pt = $prevTitle->getText() ) {
 			$query = array( 'from' => $prevTitle->getText() );
 
 			if ( $namespace ) {
diff --git a/includes/specials/SpecialChangePassword.php b/includes/specials/SpecialChangePassword.php
index f4ce8823be..dcd2443656 100644
--- a/includes/specials/SpecialChangePassword.php
+++ b/includes/specials/SpecialChangePassword.php
@@ -83,7 +83,7 @@ class SpecialChangePassword extends FormSpecialPage {
 		$request = $this->getRequest();
 
 		$oldpassMsg = $this->mOldPassMsg;
-		if ( !isset( $oldpassMsg ) ) {
+		if ( $oldpassMsg === null ) {
 			$oldpassMsg = $user->isLoggedIn() ? 'oldpassword' : 'resetpass-temp-password';
 		}
 
diff --git a/includes/specials/SpecialFileDuplicateSearch.php b/includes/specials/SpecialFileDuplicateSearch.php
index 9cf5a73c30..b6c9d55d0e 100644
--- a/includes/specials/SpecialFileDuplicateSearch.php
+++ b/includes/specials/SpecialFileDuplicateSearch.php
@@ -101,7 +101,7 @@ class FileDuplicateSearchPage extends QueryPage {
 		$this->setHeaders();
 		$this->outputHeader();
 
-		$this->filename = isset( $par ) ? $par : $this->getRequest()->getText( 'filename' );
+		$this->filename = $par !== null ? $par : $this->getRequest()->getText( 'filename' );
 		$this->file = null;
 		$this->hash = '';
 		$title = Title::newFromText( $this->filename, NS_FILE );
diff --git a/includes/specials/SpecialLinkSearch.php b/includes/specials/SpecialLinkSearch.php
index c44e8e1c59..b88e196993 100644
--- a/includes/specials/SpecialLinkSearch.php
+++ b/includes/specials/SpecialLinkSearch.php
@@ -209,7 +209,7 @@ class LinkSearchPage extends QueryPage {
 		global $wgMiserMode;
 		$params = array();
 		$params['target'] = $this->mProt . $this->mQuery;
-		if ( isset( $this->mNs ) && !$wgMiserMode ) {
+		if ( $this->mNs !== null && !$wgMiserMode ) {
 			$params['namespace'] = $this->mNs;
 		}
 
@@ -244,7 +244,7 @@ class LinkSearchPage extends QueryPage {
 			'options' => array( 'USE INDEX' => $clause )
 		);
 
-		if ( isset( $this->mNs ) && !$wgMiserMode ) {
+		if ( $this->mNs !== null && !$wgMiserMode ) {
 			$retval['conds']['page_namespace'] = $this->mNs;
 		}
 
diff --git a/includes/specials/SpecialPrefixindex.php b/includes/specials/SpecialPrefixindex.php
index b6b60d4edb..34e803d7e2 100644
--- a/includes/specials/SpecialPrefixindex.php
+++ b/includes/specials/SpecialPrefixindex.php
@@ -76,7 +76,7 @@ class SpecialPrefixindex extends SpecialAllpages {
 		);
 
 		$showme = '';
-		if ( isset( $par ) ) {
+		if ( $par !== null ) {
 			$showme = $par;
 		} elseif ( $prefix != '' ) {
 			$showme = $prefix;
@@ -167,6 +167,7 @@ class SpecialPrefixindex extends SpecialAllpages {
 		$fromList = $this->getNamespaceKeyAndText( $namespace, $from );
 		$prefixList = $this->getNamespaceKeyAndText( $namespace, $prefix );
 		$namespaces = $wgContLang->getNamespaces();
+		$res = null;
 
 		if ( !$prefixList || !$fromList ) {
 			$out = $this->msg( 'allpagesbadtitle' )->parseAsBlock();
@@ -261,9 +262,7 @@ class SpecialPrefixindex extends SpecialAllpages {
 				'</td>
 				<td id="mw-prefixindex-nav-form" class="mw-prefixindex-nav">';
 
-			if ( isset( $res ) && $res && ( $n == $this->maxPerPage ) &&
-				( $s = $res->fetchObject() )
-			) {
+			if ( $res && ( $n == $this->maxPerPage ) && ( $s = $res->fetchObject() ) ) {
 				$query = array(
 					'from' => $s->page_title,
 					'prefix' => $prefix,
diff --git a/includes/specials/SpecialWhatlinkshere.php b/includes/specials/SpecialWhatlinkshere.php
index 6488810378..d980f7995b 100644
--- a/includes/specials/SpecialWhatlinkshere.php
+++ b/includes/specials/SpecialWhatlinkshere.php
@@ -64,7 +64,7 @@ class SpecialWhatLinksHere extends IncludableSpecialPage {
 		$opts->validateIntBounds( 'limit', 0, 5000 );
 
 		// Give precedence to subpage syntax
-		if ( isset( $par ) ) {
+		if ( $par !== null ) {
 			$opts->setValue( 'target', $par );
 		}
 
-- 
2.20.1