From a469cf2c95e72e657d579324f28300dba502e451 Mon Sep 17 00:00:00 2001 From: Platonides Date: Tue, 8 Nov 2011 22:27:25 +0000 Subject: [PATCH] Mark as FIXME. This three calls leak a png filename in sys_get_temp_dir() each, tempnam() like, not the two-words filenames of RandomImageGenerator::getRandomFilenames() They aren't produced by ApiTestCaseUpload::fakeUploadFile() either. --- tests/phpunit/includes/api/ApiUploadTest.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/phpunit/includes/api/ApiUploadTest.php b/tests/phpunit/includes/api/ApiUploadTest.php index 881eebf8b5..95568e4860 100644 --- a/tests/phpunit/includes/api/ApiUploadTest.php +++ b/tests/phpunit/includes/api/ApiUploadTest.php @@ -241,7 +241,7 @@ class ApiUploadTest extends ApiTestCaseUpload { $exception = false; try { list( $result, , ) = $this->doApiRequestWithToken( $params, $session, - self::$users['uploader']->user ); + self::$users['uploader']->user ); // FIXME: leaks a temporary file } catch ( UsageException $e ) { $exception = true; } @@ -324,7 +324,7 @@ class ApiUploadTest extends ApiTestCaseUpload { $exception = false; try { list( $result, $request, $session ) = $this->doApiRequestWithToken( $params, $session, - self::$users['uploader']->user ); + self::$users['uploader']->user ); // FIXME: leaks a temporary file } catch ( UsageException $e ) { $exception = true; } @@ -382,7 +382,7 @@ class ApiUploadTest extends ApiTestCaseUpload { $exception = false; try { list( $result, $request, $session ) = $this->doApiRequestWithToken( $params, $session, - self::$users['uploader']->user ); + self::$users['uploader']->user ); // FIXME: leaks a temporary file } catch ( UsageException $e ) { $exception = true; } -- 2.20.1