From 81f4eb4b714e5563126e571d5615b0c0ac63ac0c Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Sun, 19 Aug 2018 00:06:35 -0700 Subject: [PATCH] Improve StaticArrayWriterTest and add missing @covers tag Checking for proper quoting was suggested by Krinkle in CR. Change-Id: I7fa599767017a5cfc82899bc4178de6cb34bdd02 --- tests/phpunit/includes/libs/StaticArrayWriterTest.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/phpunit/includes/libs/StaticArrayWriterTest.php b/tests/phpunit/includes/libs/StaticArrayWriterTest.php index bfb3b584c9..276fee3f6c 100644 --- a/tests/phpunit/includes/libs/StaticArrayWriterTest.php +++ b/tests/phpunit/includes/libs/StaticArrayWriterTest.php @@ -20,11 +20,15 @@ use Wikimedia\StaticArrayWriter; +/** + * @covers \Wikimedia\StaticArrayWriter + */ class StaticArrayWriterTest extends PHPUnit\Framework\TestCase { public function testCreate() { $data = [ 'foo' => 'bar', 'baz' => 'rawr', + "they're" => '"quoted properly"', ]; $writer = new StaticArrayWriter(); $actual = $writer->create( $data, "Header\nWith\nNewlines" ); @@ -36,6 +40,7 @@ class StaticArrayWriterTest extends PHPUnit\Framework\TestCase { return [ 'foo' => 'bar', 'baz' => 'rawr', + 'they\'re' => '"quoted properly"', ]; PHP; -- 2.20.1