From 8068ec255eb0d0f484dff1c456e7c5bd997dd26e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Wed, 23 Dec 2015 22:17:06 +0100 Subject: [PATCH] SpecialContributions: Simplify check for 'Special:Contributions/newbies' Added in 54615b5ea1a05caf40461b46193b4779e912f528 (per T36659) as a possibly temporary workaround, it has stuck around for six release versions now. It's not going to suddenly disappear and we shouldn't optimize this code for ease of removal :) Bug: T36659 Change-Id: I946ae7cf164f5c71b2ea4023161df7452bd1745a --- includes/specials/SpecialContributions.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/includes/specials/SpecialContributions.php b/includes/specials/SpecialContributions.php index fc9f750d84..bf3ab907f7 100644 --- a/includes/specials/SpecialContributions.php +++ b/includes/specials/SpecialContributions.php @@ -49,11 +49,7 @@ class SpecialContributions extends IncludableSpecialPage { $target = $request->getVal( 'target' ); } - // check for radiobox - if ( $request->getVal( 'contribs' ) == 'newbie' ) { - $target = 'newbies'; - $this->opts['contribs'] = 'newbie'; - } elseif ( $par === 'newbies' ) { // b/c for WMF + if ( $request->getVal( 'contribs' ) == 'newbie' || $par === 'newbies' ) { $target = 'newbies'; $this->opts['contribs'] = 'newbie'; } else { -- 2.20.1