From 2e39f834d8e7f624eeaddffe628b9c2c04623de2 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Thiemo=20M=C3=A4ttig?= Date: Thu, 20 Nov 2014 13:59:16 +0100 Subject: [PATCH] mediawiki.action.view.dblClickEdit: Do not call click on undefined Not all pages in a MediaWiki installation have an edit link. For example the pages in Wikidata do not have it. Bug: 57713 Change-Id: I842c1224d15887d59eab73f2b222c232a05c0bd9 --- .../mediawiki.action/mediawiki.action.view.dblClickEdit.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js b/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js index 3c22851e37..2be29f0963 100644 --- a/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js +++ b/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js @@ -8,7 +8,11 @@ if ( parseInt( mw.user.options.get( 'editondblclick' ), 10 ) ) { e.preventDefault(); // Trigger native HTMLElement click instead of opening URL (bug 43052) - $( '#ca-edit a' ).get( 0 ).click(); + var $a = $( '#ca-edit a' ); + // Not every page has an edit link (bug 57713) + if ( $a.length ) { + $a.get( 0 ).click(); + } } } ); } ); -- 2.20.1