From 2a4f6865a1adb90403198ff4a7d62612c3e91ce0 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 29 Mar 2019 18:36:48 +0000 Subject: [PATCH] mediawiki.user: Use then() instead of done() Makes it compatible with standard ES6 Promise, and also allows the browser to respond sooner to user input (if there was any) rather than (synchronously) continuing within this same async block. Change-Id: I82aac439cecd7680f53a82649196c9168eda6755 --- resources/src/mediawiki.user.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/src/mediawiki.user.js b/resources/src/mediawiki.user.js index d9b1227bbb..aada50c52a 100644 --- a/resources/src/mediawiki.user.js +++ b/resources/src/mediawiki.user.js @@ -173,7 +173,7 @@ var userGroups = mw.config.get( 'wgUserGroups', [] ); // Uses promise for backwards compatibility - return $.Deferred().resolve( userGroups ).done( callback ); + return $.Deferred().resolve( userGroups ).then( callback ); }, /** @@ -186,7 +186,7 @@ return getUserInfo().then( function ( userInfo ) { return userInfo.rights; }, function () { return []; } - ).done( callback ); + ).then( callback ); } } ); -- 2.20.1