From 1b4aad10e4d6b7b6e492c8ba83634413dae87a3f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Thiemo=20M=C3=A4ttig?= Date: Wed, 9 Jul 2014 17:40:35 +0200 Subject: [PATCH] Fix TitlePermissionTest failing on non-English setups This test fails on non-English MediaWiki setups. Yes, the solution looks kind of hackish, but a proper solution would require major refactoring of a lot of core classes. Please let us introduce this quick fix for now. Change-Id: I0e4fdaca5e7f844f45a2c41572e2e839640714b6 --- tests/phpunit/includes/TitlePermissionTest.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/phpunit/includes/TitlePermissionTest.php b/tests/phpunit/includes/TitlePermissionTest.php index ac80a9aa37..988a4a4c13 100644 --- a/tests/phpunit/includes/TitlePermissionTest.php +++ b/tests/phpunit/includes/TitlePermissionTest.php @@ -41,6 +41,9 @@ class TitlePermissionTest extends MediaWikiLangTestCase { NS_MEDIAWIKI => 'editinterface', ), ) ); + // Without this testUserBlock will use a non-English context on non-English MediaWiki + // installations (because of how Title::checkUserBlock is implemented) and fail. + RequestContext::resetMain(); $this->userName = 'Useruser'; $this->altUserName = 'Altuseruser'; -- 2.20.1