From: Kevin Israel <pleasestand@live.com>
Date: Sun, 29 Mar 2015 18:07:46 +0000 (-0400)
Subject: Fix ORDER BY in fixUserRegistration.php
X-Git-Tag: 1.31.0-rc.0~11935^2
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=f422ee6bf274722fbd48f7a19a59ab6e3fe9d18b;p=lhc%2Fweb%2Fwiklou.git

Fix ORDER BY in fixUserRegistration.php

Non-boolean options for select() must be provided as key-value pairs. If
provided as numbered elements, they will not end up in the generated query.

Follows-up ea406e42cd41.

Change-Id: I0364618b6a805c353cdc19a60f157df33519d87a
---

diff --git a/maintenance/fixUserRegistration.php b/maintenance/fixUserRegistration.php
index 43f4b6c0eb..40e091595e 100644
--- a/maintenance/fixUserRegistration.php
+++ b/maintenance/fixUserRegistration.php
@@ -46,13 +46,13 @@ class FixUserRegistration extends Maintenance {
 				'user',
 				'user_id',
 				array(
-					'user_id >' . $dbw->addQuotes( $lastId ),
+					'user_id > ' . $dbw->addQuotes( $lastId ),
 					'user_registration IS NULL'
 				),
 				__METHOD__,
 				array(
 					'LIMIT' => $this->mBatchSize,
-					'ORDER BY user_id ASC',
+					'ORDER BY' => 'user_id',
 				)
 			);
 			foreach ( $res as $row ) {