From: Alangi Derick <alangiderick@gmail.com>
Date: Tue, 27 Nov 2018 15:47:07 +0000 (+0100)
Subject: Fix global variable name typo in LocalIdLookupTest.php
X-Git-Tag: 1.34.0-rc.0~3420^2
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=edc11af72546b923da0fc868eb906e83dfd14058;p=lhc%2Fweb%2Fwiklou.git

Fix global variable name typo in LocalIdLookupTest.php

Per @Thiemo and @Anomie's comments on the patch, droppping dependency
of the test value to not be a global, using "dummy" in this case.

Bug: T210512
Change-Id: I26aff5fe4782837a8f52a102ae1bdbac49b748bc
---

diff --git a/tests/phpunit/includes/user/LocalIdLookupTest.php b/tests/phpunit/includes/user/LocalIdLookupTest.php
index 6ce01ca885..58441f095f 100644
--- a/tests/phpunit/includes/user/LocalIdLookupTest.php
+++ b/tests/phpunit/includes/user/LocalIdLookupTest.php
@@ -124,9 +124,8 @@ class LocalIdLookupTest extends MediaWikiTestCase {
 	 * @param bool $localDBSet $wgLocalDatabases contains the shared DB
 	 */
 	public function testIsAttachedShared( $sharedDB, $sharedTable, $localDBSet ) {
-		global $wgDBName;
 		$this->setMwGlobals( [
-			'wgSharedDB' => $sharedDB ? $wgDBName : null,
+			'wgSharedDB' => $sharedDB ? "dummy" : null,
 			'wgSharedTables' => $sharedTable ? [ 'user' ] : [],
 			'wgLocalDatabases' => $localDBSet ? [ 'shared' ] : [],
 		] );