From: Kunal Mehta <legoktm@member.fsf.org>
Date: Fri, 17 Aug 2018 23:41:02 +0000 (-0700)
Subject: TitleFormatter: Remove indirection from getText()
X-Git-Tag: 1.34.0-rc.0~4341^2~1
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=e4e3e64f3a3630f94912f79e5c36f7f48dc16744;p=lhc%2Fweb%2Fwiklou.git

TitleFormatter: Remove indirection from getText()

At the end of the day, the output is identical to LinkTarget::getText().

Change-Id: Ifddafb79d7602ba5e368cc40f99c56e22a56d506
---

diff --git a/includes/title/MediaWikiTitleCodec.php b/includes/title/MediaWikiTitleCodec.php
index daa4dd55b5..15f8ff0997 100644
--- a/includes/title/MediaWikiTitleCodec.php
+++ b/includes/title/MediaWikiTitleCodec.php
@@ -174,7 +174,7 @@ class MediaWikiTitleCodec implements TitleFormatter, TitleParser {
 	 * @return string $title->getText()
 	 */
 	public function getText( LinkTarget $title ) {
-		return $this->formatTitle( false, $title->getText(), '' );
+		return $title->getText();
 	}
 
 	/**
diff --git a/includes/title/TitleFormatter.php b/includes/title/TitleFormatter.php
index 4551d75a51..8859066aa5 100644
--- a/includes/title/TitleFormatter.php
+++ b/includes/title/TitleFormatter.php
@@ -50,7 +50,7 @@ interface TitleFormatter {
 	/**
 	 * Returns the title text formatted for display, without namespace of fragment.
 	 *
-	 * @note Only minimal normalization is applied. Consider using TitleValue::getText() directly.
+	 * @note Consider using LinkTarget::getText() directly, it's identical.
 	 *
 	 * @param LinkTarget $title The title to format
 	 *