From: Derick Alangi <alangiderick@gmail.com>
Date: Mon, 15 Apr 2019 20:14:05 +0000 (+0100)
Subject: clientpool: Remove unused parameter from constructor header
X-Git-Tag: 1.34.0-rc.0~1951^2
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=cc8a5532fdd39f6978272121445dc5b46db3aa9f;p=lhc%2Fweb%2Fwiklou.git

clientpool: Remove unused parameter from constructor header

Per https://codesearch.wmflabs.org/search/?q=SquidPurgeClient&i=nope&files=&repos=,
constructing an SquidPargeClient requires only the $server argument and
doesn't make use of $options yet. Maybe this was a WIP but for now, it's
never used, so cleaning it up.

Change-Id: I2d86ac6b17ac8dce85c05887de8eee4bb3dd28a5
---

diff --git a/includes/clientpool/SquidPurgeClient.php b/includes/clientpool/SquidPurgeClient.php
index 49d9d1c7f0..75f51ef7e3 100644
--- a/includes/clientpool/SquidPurgeClient.php
+++ b/includes/clientpool/SquidPurgeClient.php
@@ -68,9 +68,8 @@ class SquidPurgeClient {
 
 	/**
 	 * @param string $server
-	 * @param array $options
 	 */
-	public function __construct( $server, $options = [] ) {
+	public function __construct( $server ) {
 		$parts = explode( ':', $server, 2 );
 		$this->host = $parts[0];
 		$this->port = $parts[1] ?? 80;