From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Thu, 28 Feb 2019 11:37:40 +0000 (+0100)
Subject: upload: Simplify file extension extraction in UploadBase
X-Git-Tag: 1.34.0-rc.0~2384^2
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=caf66ceb91967c7734435aa2344b448bcd37a482;p=lhc%2Fweb%2Fwiklou.git

upload: Simplify file extension extraction in UploadBase

The code does the exact same, just shorter and hopefully better
readable.

Change-Id: Idd1d34927a5c027d378d1a54afd23dc7f33ee004
---

diff --git a/includes/upload/UploadBase.php b/includes/upload/UploadBase.php
index d9e8e99498..d692f1a432 100644
--- a/includes/upload/UploadBase.php
+++ b/includes/upload/UploadBase.php
@@ -947,8 +947,8 @@ abstract class UploadBase {
 		 */
 		list( $partname, $ext ) = $this->splitExtensions( $this->mFilteredName );
 
-		if ( count( $ext ) ) {
-			$this->mFinalExtension = trim( $ext[count( $ext ) - 1] );
+		if ( $ext !== [] ) {
+			$this->mFinalExtension = trim( end( $ext ) );
 		} else {
 			$this->mFinalExtension = '';