From: Chad Horohoe <demon@users.mediawiki.org>
Date: Wed, 11 Jun 2008 19:57:14 +0000 (+0000)
Subject: No point in fetching the result in Database::unlock() if we're not using it anyway.
X-Git-Tag: 1.31.0-rc.0~47043
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=a89f49bc288adec941b59c9723a4cc4fe1c78fda;p=lhc%2Fweb%2Fwiklou.git

No point in fetching the result in Database::unlock() if we're not using it anyway.
---

diff --git a/includes/Database.php b/includes/Database.php
index 7e80c509fc..f3f98e52e2 100644
--- a/includes/Database.php
+++ b/includes/Database.php
@@ -2261,13 +2261,15 @@ class Database {
 	/**
 	 * Release a lock.
 	 * 
+	 * @todo fixme - Figure out a way to return a bool
+	 * based on successful lock release.
+	 * 
 	 * @param string $lockName Name of lock to release
 	 * @param string $method Name of method calling us
 	 */
 	public function unlock( $lockName, $method ) {
 		$lockName = $this->addQuotes( $lockName );
 		$result = $this->query( "SELECT RELEASE_LOCK($lockName)", $method );
-		$this->fetchObject( $result );
 		$this->freeResult( $result );
 	}
 }