From: kaldari <rkaldari@wikimedia.org>
Date: Tue, 3 Dec 2013 19:12:32 +0000 (-0800)
Subject: Add 'mediawiki.ui.button' CSS module
X-Git-Tag: 1.31.0-rc.0~17579^2
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=9e4e58bce8d10f65cf298b39f48e86c41b6a82b8;p=lhc%2Fweb%2Fwiklou.git

Add 'mediawiki.ui.button' CSS module

This splits the button styling out from mediawiki.ui into a
separate module.

This is an alternative to https://gerrit.wikimedia.org/r/#/c/87296/

This migration will be implemented in 3 steps, of which this is the
first:
1. Add new mediawiki.ui.button module to core
2. Add mediawiki.ui.button dependancy to all extensions and core
   features that currently use mediawiki.ui (and have buttons)
3. Remove button styles from mediawiki.ui

Change-Id: Ia375d848df15afe6ddc3f3f19e43249d6c0706f0
---

diff --git a/resources/Resources.php b/resources/Resources.php
index d2a06b782e..3f78a12b58 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1187,6 +1187,16 @@ return array(
 			'vector' => 'resources/mediawiki.ui/vector.less',
 		),
 		'position' => 'top',
+		'targets' => array( 'desktop', 'mobile' ),
+	),
+	// Lightweight module for button styles
+	'mediawiki.ui.button' => array(
+		'skinStyles' => array(
+			'default' => 'resources/mediawiki.ui/components/default/buttons.less',
+			'vector' => 'resources/mediawiki.ui/components/vector/buttons.less',
+		),
+		'position' => 'top',
+		'targets' => array( 'desktop', 'mobile' ),
 	),
 
 	/* OOJS */
@@ -1198,5 +1208,4 @@ return array(
 		),
 		'targets' => array( 'desktop', 'mobile' ),
 	),
-
 );
diff --git a/resources/mediawiki.ui/default.less b/resources/mediawiki.ui/default.less
index 036db5f509..05045d59a6 100644
--- a/resources/mediawiki.ui/default.less
+++ b/resources/mediawiki.ui/default.less
@@ -3,6 +3,8 @@
  * Vector.
  */
 
+// FIXME: remove import for button styles as soon as extensions using mediawiki.ui are
+// updated to use mediawiki.ui.button as well.
 @import "components/utilities";
 @import "components/default/buttons";
 @import "components/default/forms";
diff --git a/resources/mediawiki.ui/vector.less b/resources/mediawiki.ui/vector.less
index a3475628e5..f736b5ca9e 100644
--- a/resources/mediawiki.ui/vector.less
+++ b/resources/mediawiki.ui/vector.less
@@ -2,6 +2,8 @@
  * Provide Agora appearance for mw-ui-* classes when using the Vector skin.
  */
 
+// FIXME: remove import for button styles as soon as extensions using mediawiki.ui are
+// updated to use mediawiki.ui.button as well.
 @import "components/utilities";
 @import "components/vector/buttons";
 @import "components/vector/forms";