From: Yuri Astrakhan <yurik@wikimedia.org>
Date: Thu, 19 Dec 2013 00:27:32 +0000 (-0500)
Subject: Add logging for "Invalid message parameter"
X-Git-Tag: 1.31.0-rc.0~17550
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=5b4c232ab2c4a34411f595100988862fc035e92e;p=lhc%2Fweb%2Fwiklou.git

Add logging for "Invalid message parameter"

Records a full stacktrace for this warning

Bug: 58676
Change-Id: I234b525b04168eee6085d44fbf0e0d8ac3d0af91
---

diff --git a/includes/Message.php b/includes/Message.php
index 6ac87b3e25..dd22844dc3 100644
--- a/includes/Message.php
+++ b/includes/Message.php
@@ -817,11 +817,12 @@ class Message {
 			} elseif ( isset( $param['bitrate'] ) ) {
 				return array( 'before', $this->language->formatBitrate( $param['bitrate'] ) );
 			} else {
-				trigger_error(
-					'Invalid parameter for message "' . $this->getKey() . '": ' .
-					htmlspecialchars( serialize( $param ) ),
-					E_USER_WARNING
-				);
+				$warning = 'Invalid parameter for message "' . $this->getKey() . '": ' .
+					htmlspecialchars( serialize( $param ) );
+				trigger_error( $warning, E_USER_WARNING );
+				$e = new Exception;
+				wfDebugLog( 'Bug58676', $warning . "\n" . $e->getTraceAsString() );
+
 				return array( 'before', '[INVALID]' );
 			}
 		} elseif ( $param instanceof Message ) {