From: Tim Starling <tstarling@users.mediawiki.org>
Date: Tue, 20 Dec 2011 04:36:27 +0000 (+0000)
Subject: Don't suppress warnings when attempting file creation for the second time, this masks... 
X-Git-Tag: 1.31.0-rc.0~25886
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=1312f8a626353f9a2268a6955ac008a2074961f5;p=lhc%2Fweb%2Fwiklou.git

Don't suppress warnings when attempting file creation for the second time, this masks important error messages
---

diff --git a/includes/filerepo/backend/lockmanager/FSLockManager.php b/includes/filerepo/backend/lockmanager/FSLockManager.php
index 4a5fb296dd..919906f5e7 100644
--- a/includes/filerepo/backend/lockmanager/FSLockManager.php
+++ b/includes/filerepo/backend/lockmanager/FSLockManager.php
@@ -83,9 +83,7 @@ class FSLockManager extends LockManager {
 			wfRestoreWarnings();
 			if ( !$handle ) { // lock dir missing?
 				wfMkdirParents( $this->lockDir );
-				wfSuppressWarnings();
 				$handle = fopen( $this->getLockPath( $key ), 'a+' ); // try again
-				wfRestoreWarnings();
 			}
 			if ( $handle ) {
 				// Either a shared or exclusive lock