Return true on success, not just false on failure. A bit of documentation as well :-)
authorChad Horohoe <demon@users.mediawiki.org>
Wed, 2 Jul 2008 19:41:58 +0000 (19:41 +0000)
committerChad Horohoe <demon@users.mediawiki.org>
Wed, 2 Jul 2008 19:41:58 +0000 (19:41 +0000)
includes/AutoLoader.php

index 540a4d8..f1d8a7d 100644 (file)
@@ -463,6 +463,14 @@ class AutoLoader {
 
        );
 
+       /**
+        * autoload - take a class name and attempt to load it
+        * 
+        * @param string $className Name of class we're looking for.
+        * @return bool Returning false is important on failure as
+        * it allows Zend to try and look in other registered autoloaders
+        * as well. 
+        */
        static function autoload( $className ) {
                global $wgAutoloadClasses;
 
@@ -484,7 +492,7 @@ class AutoLoader {
                        if ( !$filename ) {
                                # Give up
                                wfProfileOut( __METHOD__ );
-                               return;
+                               return false;
                        }
                }
 
@@ -495,6 +503,7 @@ class AutoLoader {
                }
                require( $filename );
                wfProfileOut( __METHOD__ );
+               return true;
        }
 
        static function loadAllExtensions() {