From cc6470252707f9959020047fe68bf7cfc50fa1a0 Mon Sep 17 00:00:00 2001 From: Krinkle Date: Thu, 4 Jun 2015 15:00:02 +0000 Subject: [PATCH] Revert "Add 'mediawiki.skinning.logo' module" This is redundant and creates more modules than necessary. The use case of not wanting to load "mediawiki.skinning.interface" in a custom skin is invalid. For this exact purpose we already created the ResourceLoaderSkinModule class which is generic and re-usable. Skins can add that class name to their stylesheet file module to append the logo styles. This way involves no extra modules. Not in core, and not in any skin. This reverts commit 43346e1527dc6f30e33c5acd4f479acc0eab7d0a. Change-Id: I2b0a1d5ed72f2d5338ad26af6e04227bec45dcc1 --- resources/Resources.php | 8 -------- 1 file changed, 8 deletions(-) diff --git a/resources/Resources.php b/resources/Resources.php index 7b7a31c626..844f232b66 100644 --- a/resources/Resources.php +++ b/resources/Resources.php @@ -109,7 +109,6 @@ return array( // Used in the web installer. Test it after modifying this definition! 'mediawiki.skinning.interface' => array( 'position' => 'top', - // Display wiki logo on .mw-wiki-logo elements. 'class' => 'ResourceLoaderSkinModule', 'styles' => array( 'resources/src/mediawiki.skinning/elements.css' => array( 'media' => 'screen' ), @@ -136,13 +135,6 @@ return array( ), ), - // Display wiki logo on .mw-wiki-logo elements. - // This is also part of 'mediawiki.skinning.interface' module; the skin shouldn't load them both. - 'mediawiki.skinning.logo' => array( - 'position' => 'top', - 'class' => 'ResourceLoaderSkinModule', - ), - /* jQuery */ 'jquery' => array( -- 2.20.1