From c68ae9d56127da6d11a7e52ec337b0924195f6e9 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Gerg=C5=91=20Tisza?= Date: Fri, 20 May 2016 14:27:56 +0000 Subject: [PATCH] registration: Ignore short variables in convertExtensionToRegistration substr returns false when the string is shorter than the initial position, which makes array_key_exists freak out. Change-Id: I38c2dd3a1ae5d700d66ff590dda4be67e4dc5514 --- maintenance/convertExtensionToRegistration.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/maintenance/convertExtensionToRegistration.php b/maintenance/convertExtensionToRegistration.php index f9dd58c299..aab20879d4 100644 --- a/maintenance/convertExtensionToRegistration.php +++ b/maintenance/convertExtensionToRegistration.php @@ -94,6 +94,9 @@ class ConvertExtensionToRegistration extends Maintenance { $globalSettings = $this->getAllGlobals(); foreach ( $vars as $name => $value ) { $realName = substr( $name, 2 ); // Strip 'wg' + if ( $realName === false ) { + continue; + } // If it's an empty array that we likely set, skip it if ( is_array( $value ) && count( $value ) === 0 && in_array( $realName, $__settings ) ) { -- 2.20.1