From c0ed76d715a346372473302441451094da109d97 Mon Sep 17 00:00:00 2001
From: umherirrender <umherirrender_de.wp@web.de>
Date: Sat, 15 Mar 2014 10:59:04 +0100
Subject: [PATCH] Add a 'revdelete-selected-file' message on
 Special:RevisionDelete

This allows a file adjusted message when delete file versions and can
make clear the difference between deleting a revision of the file
description page or a version of the file.

Also renamed 'revdelete-selected' to 'revdelete-selected-text' to be
able to reorder the params, this allows using the same code for each
type (log, text and file)

Change-Id: I02514eda2f267ede16b4298ed5cae64c6787f79d
---
 includes/specials/SpecialRevisiondelete.php | 13 +++++++------
 languages/messages/MessagesEn.php           |  5 +++--
 languages/messages/MessagesQqq.php          | 19 +++++++++++++++----
 maintenance/language/messages.inc           |  3 ++-
 4 files changed, 27 insertions(+), 13 deletions(-)

diff --git a/includes/specials/SpecialRevisiondelete.php b/includes/specials/SpecialRevisiondelete.php
index 05c8872e5f..7abc25325f 100644
--- a/includes/specials/SpecialRevisiondelete.php
+++ b/includes/specials/SpecialRevisiondelete.php
@@ -67,30 +67,35 @@ class SpecialRevisionDelete extends UnlistedSpecialPage {
 			'success' => 'revdelete-success',
 			'failure' => 'revdelete-failure',
 			'text' => 'revdelete-text-text',
+			'selected'=> 'revdelete-selected-text',
 		),
 		'archive' => array(
 			'check-label' => 'revdelete-hide-text',
 			'success' => 'revdelete-success',
 			'failure' => 'revdelete-failure',
 			'text' => 'revdelete-text-text',
+			'selected'=> 'revdelete-selected-text',
 		),
 		'oldimage' => array(
 			'check-label' => 'revdelete-hide-image',
 			'success' => 'revdelete-success',
 			'failure' => 'revdelete-failure',
 			'text' => 'revdelete-text-file',
+			'selected'=> 'revdelete-selected-file',
 		),
 		'filearchive' => array(
 			'check-label' => 'revdelete-hide-image',
 			'success' => 'revdelete-success',
 			'failure' => 'revdelete-failure',
 			'text' => 'revdelete-text-file',
+			'selected'=> 'revdelete-selected-file',
 		),
 		'logging' => array(
 			'check-label' => 'revdelete-hide-name',
 			'success' => 'logdelete-success',
 			'failure' => 'logdelete-failure',
 			'text' => 'logdelete-text',
+			'selected' => 'logdelete-selected',
 		),
 	);
 
@@ -335,12 +340,8 @@ class SpecialRevisionDelete extends UnlistedSpecialPage {
 	protected function showForm() {
 		$userAllowed = true;
 
-		if ( $this->typeName == 'logging' ) {
-			$this->getOutput()->addWikiMsg( 'logdelete-selected', $this->getLanguage()->formatNum( count( $this->ids ) ) );
-		} else {
-			$this->getOutput()->addWikiMsg( 'revdelete-selected',
-				$this->targetObj->getPrefixedText(), count( $this->ids ) );
-		}
+		$this->getOutput()->wrapWikiMsg( "<strong>$1</strong>", array( $this->typeLabels['selected'],
+			$this->getLanguage()->formatNum( count( $this->ids ) ), $this->targetObj->getPrefixedText() ) );
 
 		$this->getOutput()->addHTML( "<ul>" );
 
diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php
index df17d8fca0..f1e87e8075 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -1708,8 +1708,9 @@ function, the specified revision does not exist, or you are attempting to hide t
 'revdelete-no-file'           => 'The file specified does not exist.',
 'revdelete-show-file-confirm' => 'Are you sure you want to view a deleted revision of the file "<nowiki>$1</nowiki>" from $2 at $3?',
 'revdelete-show-file-submit'  => 'Yes',
-'revdelete-selected'          => '<strong>{{PLURAL:$2|Selected revision|Selected revisions}} of [[:$1]]:</strong>',
-'logdelete-selected'          => '<strong>{{PLURAL:$1|Selected log event|Selected log events}}:</strong>',
+'revdelete-selected-text'     => '{{PLURAL:$1|Selected revision|Selected revisions}} of [[:$2]]:',
+'revdelete-selected-file'     => '{{PLURAL:$1|Selected file version|Selected file versions}} of [[:$2]]:',
+'logdelete-selected'          => '{{PLURAL:$1|Selected log event|Selected log events}}:',
 'revdelete-text-text'         => 'Deleted revisions will still appear in the page history, but parts of their content will be inaccessible to the public.',
 'revdelete-text-file'         => 'Deleted file versions will still appear in the file history, but parts of their content will be inaccessible to the public.',
 'logdelete-text'              => 'Deleted log events will still appear in the logs, but parts of their content will be inaccessible to the public.',
diff --git a/languages/messages/MessagesQqq.php b/languages/messages/MessagesQqq.php
index 7a8495a8d6..ae59733868 100644
--- a/languages/messages/MessagesQqq.php
+++ b/languages/messages/MessagesQqq.php
@@ -2482,18 +2482,29 @@ Parameters:
 'revdelete-show-file-submit' => 'Reply to {{msg-mw|Revdelete-show-file-confirm}}.
 
 {{Identical|Yes}}',
-'revdelete-selected' => '{{RevisionDelete}}
+'revdelete-selected-text' => '{{RevisionDelete}}
 Parameters:
-* $1 - page title
-* $2 - number of revisions
+* $1 - number of revisions
+* $2 - page title
+See also:
+* {{msg-mw|Logdelete-selected}}
+* {{msg-mw|Revdelete-selected-file}}
+[[File:RevDelete Special-RevisionDelete (r60428).png|frame|center|Screenshot of the interface]]',
+'revdelete-selected-file' => '{{RevisionDelete}}
+Parameters:
+* $1 - number of file versions
+* $2 - file name
 See also:
 * {{msg-mw|Logdelete-selected}}
+* {{msg-mw|Revdelete-selected-text}}
 [[File:RevDelete Special-RevisionDelete (r60428).png|frame|center|Screenshot of the interface]]',
 'logdelete-selected' => '{{RevisionDelete}}
 Parameters:
 * $1 - number of log events
+* $2 - localized name of Special:Log, maybe with type as subpage [unused]
 See also:
-* {{msg-mw|Revdelete-selected}}',
+* {{msg-mw|Revdelete-selected-text}}
+* {{msg-mw|Revdelete-selected-file}}',
 'revdelete-text-text' => '{{RevisionDelete}}
 This is the introduction explaining the feature.
 See also: {{msg-mw|revdelete-text-file}}, {{msg-mw|logdelete-text}}, {{msg-mw|revdelete-text-others}}',
diff --git a/maintenance/language/messages.inc b/maintenance/language/messages.inc
index d4fdfeebb2..a2694a17b6 100644
--- a/maintenance/language/messages.inc
+++ b/maintenance/language/messages.inc
@@ -868,7 +868,8 @@ $wgMessageStructure = array(
 		'revdelete-no-file',
 		'revdelete-show-file-confirm',
 		'revdelete-show-file-submit',
-		'revdelete-selected',
+		'revdelete-selected-text',
+		'revdelete-selected-file',
 		'logdelete-selected',
 		'revdelete-text-text',
 		'revdelete-text-file',
-- 
2.20.1