From 5af0c8f2be29f6a54a33988a57fdddc7cc366d86 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Fri, 17 Mar 2017 02:21:34 +0100 Subject: [PATCH] ResourceLoaderOOUIImageModule: Actually load non-default themes' images Values in SkinOOUIThemes are TitleCase, but these filenames are lowercase. And we silently ignore missing files. This only worked for the default theme, which is hardcoded to lowercase 'mediawiki' above. Change-Id: I5b14d65a8f7d5219acfa2a40eabbb13617833b26 --- includes/resourceloader/ResourceLoaderOOUIImageModule.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/resourceloader/ResourceLoaderOOUIImageModule.php b/includes/resourceloader/ResourceLoaderOOUIImageModule.php index 29f5ccedb5..14e5c2691e 100644 --- a/includes/resourceloader/ResourceLoaderOOUIImageModule.php +++ b/includes/resourceloader/ResourceLoaderOOUIImageModule.php @@ -41,7 +41,7 @@ class ResourceLoaderOOUIImageModule extends ResourceLoaderImageModule { foreach ( $themes as $skin => $theme ) { // Find the path to the JSON file which contains the actual image definitions for this theme // TODO Allow extensions to specify this path somehow - $dataPath = $rootPath . '/' . $theme . '/' . $name . '.json'; + $dataPath = $rootPath . '/' . strtolower( $theme ) . '/' . $name . '.json'; $localDataPath = $this->localBasePath . '/' . $dataPath; // If there's no file for this module of this theme, that's okay, it will just use the defaults -- 2.20.1