From: Derick Alangi <alangiderick@gmail.com>
Date: Wed, 11 Sep 2019 17:41:05 +0000 (+0100)
Subject: deferred: Fix MW version number when hard deprecating to '1.34'
X-Git-Tag: 1.34.0-rc.0~260^2
X-Git-Url: http://git.cyclocoop.org/%22.htmlspecialchars%28%24url_syndic%29.%22?a=commitdiff_plain;h=d441507260afc8c987403034587843f890008aaa;p=lhc%2Fweb%2Fwiklou.git

deferred: Fix MW version number when hard deprecating to '1.34'

Should be string or bool and not a float. The reason 49bbfc7 was
not triggered is because the deprecated code path is no longer being
executed in production.

Change-Id: Ieeffb8a6cc7177c52b4c54d66152c90ded1dc248
---

diff --git a/includes/deferred/SearchUpdate.php b/includes/deferred/SearchUpdate.php
index a508746c55..84f6fc0eaf 100644
--- a/includes/deferred/SearchUpdate.php
+++ b/includes/deferred/SearchUpdate.php
@@ -50,7 +50,7 @@ class SearchUpdate implements DeferrableUpdate {
 	 */
 	public function __construct( $id, $title, $c = null ) {
 		if ( is_string( $title ) ) {
-			wfDeprecated( __METHOD__ . " with a string for the title", 1.34 );
+			wfDeprecated( __METHOD__ . " with a string for the title", '1.34' );
 			$this->title = Title::newFromText( $title );
 			if ( $this->title === null ) {
 				throw new InvalidArgumentException( "Cannot construct the title: $title" );
@@ -62,10 +62,10 @@ class SearchUpdate implements DeferrableUpdate {
 		$this->id = $id;
 		// is_string() check is back-compat for ApprovedRevs
 		if ( is_string( $c ) ) {
-			wfDeprecated( __METHOD__ . " with a string for the content", 1.34 );
+			wfDeprecated( __METHOD__ . " with a string for the content", '1.34' );
 			$c = new TextContent( $c );
 		} elseif ( is_bool( $c ) ) {
-			wfDeprecated( __METHOD__ . " with a boolean for the content", 1.34 );
+			wfDeprecated( __METHOD__ . " with a boolean for the content", '1.34' );
 			$c = null;
 		}
 		$this->content = $c;