From: Umherirrender <umherirrender_de.wp@web.de>
Date: Tue, 2 Jul 2019 20:07:25 +0000 (+0200)
Subject: Fix use of argument perfLogFilename in convertLinks.php
X-Git-Tag: 1.34.0-rc.0~358^2
X-Git-Url: http://git.cyclocoop.org/%22.htmlspecialchars%28%24url_syndic%29.%22?a=commitdiff_plain;h=c91157d649eb34e88af1bb983420b19b4d04eda7;p=lhc%2Fweb%2Fwiklou.git

Fix use of argument perfLogFilename in convertLinks.php

Maintenance::getArg needs a number to get the argument, not a string
Reorg the hasOption calls to match the addArg from constructor

Change-Id: Ice7013affb328363daf6e831010de4640583f486
---

diff --git a/maintenance/convertLinks.php b/maintenance/convertLinks.php
index 02152f7b66..2dcabe332b 100644
--- a/maintenance/convertLinks.php
+++ b/maintenance/convertLinks.php
@@ -100,10 +100,10 @@ class ConvertLinks extends Maintenance {
 		# not used yet; highest row number from links table to process
 		# $finalRowOffset = 0;
 
+		$this->logPerformance = $this->hasOption( 'logperformance' );
+		$perfLogFilename = $this->getArg( 1, "convLinksPerf.txt" );
 		$overwriteLinksTable = !$this->hasOption( 'keep-links-table' );
 		$noKeys = $this->hasOption( 'noKeys' );
-		$this->logPerformance = $this->hasOption( 'logperformance' );
-		$perfLogFilename = $this->getArg( 'perfLogFilename', "convLinksPerf.txt" );
 
 		# --------------------------------------------------------------------