From: Umherirrender <umherirrender_de.wp@web.de>
Date: Fri, 19 Apr 2019 18:18:22 +0000 (+0200)
Subject: Relax SpecialPageFatalTest about deprecation notices
X-Git-Tag: 1.34.0-rc.0~1899^2
X-Git-Url: http://git.cyclocoop.org/%22.htmlspecialchars%28%24url_syndic%29.%22?a=commitdiff_plain;h=7d7820fb4a83b4cbb3800a7080563e2a5dcaa4d4;p=lhc%2Fweb%2Fwiklou.git

Relax SpecialPageFatalTest about deprecation notices

Deprecation notice from SpecialPageFatalTest is the most merge blocker
since merge of I8fb26380724b6b12bf08458dbff2e00b759d219b
Deprecation can occur at any time and than break many extensions to
merge, even there are still working.
Ignore deprecation as before, but keep the error and notices

Change-Id: Idcbc38b662c569fbe8e778a6b1ab815db332dc08
---

diff --git a/tests/phpunit/structure/SpecialPageFatalTest.php b/tests/phpunit/structure/SpecialPageFatalTest.php
index 97797cacf6..026b903250 100644
--- a/tests/phpunit/structure/SpecialPageFatalTest.php
+++ b/tests/phpunit/structure/SpecialPageFatalTest.php
@@ -32,6 +32,9 @@ class SpecialPageFatalTest extends MediaWikiTestCase {
 
 		try {
 			$executor->executeSpecialPage( $page, '', null, null, $user );
+		} catch ( \PHPUnit\Framework\Error\Deprecated $deprecated ) {
+			// Allow deprecation,
+			// this test want to check fatals or other things breaking the extension
 		} catch ( \PHPUnit\Framework\Error\Error $error ) {
 			// Let phpunit settings working:
 			// - convertErrorsToExceptions="true"