From: Derick Alangi <alangiderick@gmail.com>
Date: Thu, 4 Apr 2019 10:27:22 +0000 (+0100)
Subject: resourceloader: Fix return type doc for getSelectors() method
X-Git-Tag: 1.34.0-rc.0~2162^2
X-Git-Url: http://git.cyclocoop.org/%22.htmlspecialchars%28%24url_syndic%29.%22?a=commitdiff_plain;h=6aed4cefdc4ac02672fc5c0ebe64c089354d5050;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Fix return type doc for getSelectors() method

So I've checked and this method should return an array and this array
specifically is an array of strings (string[]). In addition, remove an
irrelevant semicolon after foreach().

Change-Id: Id7dffe882583a7555d87a5b9c409584478c30a8c
---

diff --git a/includes/resourceloader/ResourceLoaderImageModule.php b/includes/resourceloader/ResourceLoaderImageModule.php
index d06e8ac4c7..9b50d80f69 100644
--- a/includes/resourceloader/ResourceLoaderImageModule.php
+++ b/includes/resourceloader/ResourceLoaderImageModule.php
@@ -220,7 +220,7 @@ class ResourceLoaderImageModule extends ResourceLoaderModule {
 
 	/**
 	 * Get CSS selector templates used by this module.
-	 * @return string
+	 * @return string[]
 	 */
 	public function getSelectors() {
 		$this->loadFromDefinition();
@@ -428,7 +428,7 @@ class ResourceLoaderImageModule extends ResourceLoaderModule {
 			'selectorWithVariant',
 		] as $member ) {
 			$options[$member] = $this->{$member};
-		};
+		}
 
 		$summary[] = [
 			'options' => $options,