jenkins-bot [Tue, 12 Apr 2016 21:22:26 +0000 (21:22 +0000)]
Merge "virtualrest: Small doc fix"
jenkins-bot [Tue, 12 Apr 2016 21:18:56 +0000 (21:18 +0000)]
Merge "Revert "Measure commitMasterChanges() run time""
Aaron Schulz [Tue, 12 Apr 2016 20:53:36 +0000 (13:53 -0700)]
virtualrest: Small doc fix
Change-Id: Ie162eb88b4afc492b10c75f00b9725767e21ffeb
Translation updater bot [Tue, 12 Apr 2016 20:15:08 +0000 (22:15 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I95fb9e364f3268eddab39b9abe4c68c62a1ec11a
Ori Livneh [Tue, 12 Apr 2016 19:24:42 +0000 (19:24 +0000)]
Merge "Don't report image cache hits / misses"
Ori.livneh [Tue, 12 Apr 2016 18:48:25 +0000 (18:48 +0000)]
Revert "Measure commitMasterChanges() run time"
This reverts commit
efb441883937. This is the biggest metric
by statsd traffic volume on the Wikimedia cluster. Please re-introduce this
only with sampling.
Bug: T101141
Change-Id: I7bc3b3aaa98dcefe1a80a4f458a83232c29a27ea
jenkins-bot [Tue, 12 Apr 2016 18:58:18 +0000 (18:58 +0000)]
Merge "Do not validate relevant user name"
Ori Livneh [Tue, 12 Apr 2016 18:30:21 +0000 (11:30 -0700)]
Don't report image cache hits / misses
This single metric is responsible for a substantial proportion of overall
statsd traffic on the Wikimedia cluster, per the task cited below. Nobody is
closely monitoring this statistic. We can reintroduce it with sampling at a
later date if it is deemed to be useful.
Bug: T101141
Change-Id: I6457cb91d527ce42c0918ac4e80613e6b59061ac
jenkins-bot [Tue, 12 Apr 2016 17:29:29 +0000 (17:29 +0000)]
Merge "Add preference for watching uploaded files"
Brad Jorsch [Mon, 11 Apr 2016 17:36:38 +0000 (13:36 -0400)]
Fix core DB data in unit testing
Iec4ed4c8 made it so addCoreDBData() only gets called once. Which is
nice, except for the fact that it means any test that puts
'user_groups' into $this->tablesUsed is going to cause UTSysop to no
longer be a sysop, so any later test that expects it to be one is going
to mysteriously fail.
The fix is to make resetDB() actually clear out the 'user' table when
requested, but then to re-call addCoreDBData() so UTSysop is still
there.
This might break extension tests if they're relying on the 'user' table
never being cleared even if it's specified in $this->tablesUsed, but
hopefully that's not often the case.
Bug: T132411
Change-Id: If251739fd486544f54a0c07edcc24aeef0998342
Depends-On: I0546a4f18e0751d209b6b7c6cd42973f25828313
Depends-On: I4924ae941b3844b39dd3f44c6986c3bf29b0d62a
jenkins-bot [Tue, 12 Apr 2016 10:33:13 +0000 (10:33 +0000)]
Merge "Reduce code duplication in MessageCache"
Adrian Heine [Thu, 7 Apr 2016 09:56:06 +0000 (11:56 +0200)]
Reduce code duplication in MessageCache
Change-Id: I3432958c8f81b7a33079b7933e85b87ced7363fa
Aaron Schulz [Mon, 11 Apr 2016 21:49:27 +0000 (14:49 -0700)]
Flag triggerOpportunisticLinksUpdate() behind $wgMiserMode
This has caused job flood or DB load problems too often.
Bug: T132318
Change-Id: Ieeaf047e748bdfb980d4d5511c22890bd6f28c67
Ori Livneh [Mon, 11 Apr 2016 23:41:57 +0000 (16:41 -0700)]
Cache first-letter data in APC, if available
I noticed that `frwiki:first-letters:fr:fr:4.8.1.1` was at the very top of keys
sorted by bandwidth (that is, reqs/sec * size) on one of the memcache servers
on WMF prod.
The data takes ~60 - 80ms to compute, in case of a cache miss. That's not
enough to justify using a tiered cache abstraction here, IMO.
Change-Id: If81ce8f86f2c378565f1f6a0dd2c04dee825c4e9
jenkins-bot [Mon, 11 Apr 2016 22:56:29 +0000 (22:56 +0000)]
Merge "Convert Special:Search input to OOUI"
Aaron Schulz [Mon, 11 Apr 2016 20:29:46 +0000 (13:29 -0700)]
Increase triggerOpportunisticLinksUpdate() backoff TTL
Make use of the expected TTL for the links to become
possible stale, instead of the hard-coded value of
60 seconds. Use a minimum of 3600.
Heavily used Commons templates, for example, lower
the parser cache TTL to 86400. Enqueuing jobs before
that time passes is a waste.
Bug: T132318
Change-Id: I9a3c088db9dd1747b8e99ccf7ec4633e7f01fe7b
jenkins-bot [Mon, 11 Apr 2016 21:48:35 +0000 (21:48 +0000)]
Merge "Thumbnails: allow overflow inside thumbnails"
jenkins-bot [Mon, 11 Apr 2016 21:20:52 +0000 (21:20 +0000)]
Merge "jquery.makeCollapsible: Don't ignore clicks on fake links without href"
Catrope [Mon, 11 Apr 2016 20:37:32 +0000 (20:37 +0000)]
Revert "Allow reset of global services."
Completely breaks login.
This reverts commit
8e7a0a0912bb98a4a12375b354e23f03262bf213.
Change-Id: Ide7ab5632e987e81374c21173df6ab3998649df7
jenkins-bot [Mon, 11 Apr 2016 20:36:58 +0000 (20:36 +0000)]
Merge "Revert "Make WatchedItemStore use MediaWikiServices""
Catrope [Mon, 11 Apr 2016 20:25:47 +0000 (20:25 +0000)]
Revert "Make WatchedItemStore use MediaWikiServices"
In order to cleanly revert "Allow reset of global services"
which breaks login.
This reverts commit
99e8d45b50993113b26ced7c8bb91e44c7d908b1.
Change-Id: Iae7f7b7b7083345dd50c313ee68e2e814f130f1a
jenkins-bot [Mon, 11 Apr 2016 20:14:19 +0000 (20:14 +0000)]
Merge "Fix RebuildLocalisationCache bug from MediaWikiServices"
Translation updater bot [Mon, 11 Apr 2016 19:57:01 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I065f082606ccb1d6df353f503ee8f393d8d6466b
Bryan Davis [Mon, 11 Apr 2016 19:11:03 +0000 (13:11 -0600)]
Fix RebuildLocalisationCache bug from MediaWikiServices
Revert changes to rebuildLocalisationCache.php introduced in Ie98bf5a.
The forked children do not need separate service connections and the
reset process fails due to MW_SERVICE_BOOTSTRAP_COMPLETE being defined.
Bug: T132370
Change-Id: I0d7ddcd66e7c6945fabd91fea29a48805bf14793
jenkins-bot [Mon, 11 Apr 2016 18:39:36 +0000 (18:39 +0000)]
Merge "Add templateOverridesBySection to multi LBFactory"
jenkins-bot [Mon, 11 Apr 2016 17:45:49 +0000 (17:45 +0000)]
Merge "Normalize `input[type="search"]`"
jenkins-bot [Mon, 11 Apr 2016 16:41:18 +0000 (16:41 +0000)]
Merge "RightsLogFormatter: Use DB key to generate foreign user link"
jenkins-bot [Mon, 11 Apr 2016 16:34:12 +0000 (16:34 +0000)]
Merge "Finish stash uploads with upload dialog"
Brad Jorsch [Mon, 11 Apr 2016 15:50:42 +0000 (11:50 -0400)]
Run generateLocalAutoload.php
Ie98bf5af5 was apparently done by hand.
Change-Id: I323391340dbcc2f25bc849bbbb489142e79bb5ed
addshore [Wed, 6 Apr 2016 10:46:50 +0000 (11:46 +0100)]
Make WatchedItemStore use MediaWikiServices
Change-Id: I5c8c1a652a35e055d8d65753a60c0d1684e1c37d
daniel [Mon, 12 Oct 2015 08:05:45 +0000 (10:05 +0200)]
Allow reset of global services.
This change provides a mechanism to reset global service instances
in an orderly manner. There are three use cases for this:
* the installation process
* forking processes
* integration tests (which must of the existing phpunit tests are)
Depends-On: I5d638ad415fc3840186a0beaa09ac02ea688539b
Change-Id: Ie98bf5af59208f186dba59a9e971c72ea0b63e69
addshore [Mon, 11 Apr 2016 12:34:20 +0000 (13:34 +0100)]
Add missing use MWException to SessionManager
Change-Id: I098e719cd888400191438bb0c4deeaaff1aa32dd
Derk-Jan Hartman [Mon, 11 Apr 2016 11:05:14 +0000 (13:05 +0200)]
Thumbnails: allow overflow inside thumbnails
overflow:hidden on the thumbnail has been in place like this for a
long time. One of the primary reasons was for long sentences in the
thumbcaption. For that, modern browsers now support word-wrap.
I know of no good reasons why overflow would have to apply to the
rest of the frame. Therfor moved to thumbcaption only, and added
word-wrap.
Bug: T132306
Change-Id: I1953683fa2a6d22ed82bac1acd37e5cb12636381
jenkins-bot [Mon, 11 Apr 2016 01:57:32 +0000 (01:57 +0000)]
Merge "Swap exif-pixelydimension and exif-pixelxdimension messages"
Translation updater bot [Sun, 10 Apr 2016 17:14:49 +0000 (19:14 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I01a967bb1fc77fa9a4f8dd9c8bab4e238b682cd5
jenkins-bot [Sun, 10 Apr 2016 05:30:11 +0000 (05:30 +0000)]
Merge "User.php: Update 'setEmailWithConfirmation' for notification email"
Volker E [Sun, 10 Apr 2016 02:18:49 +0000 (19:18 -0700)]
Normalize `input[type="search"]`
Limiting property `-webkit-appearance` to `input[type="search"]` only,
as it's the element this rule is targeting for instead of unnecessarily
applying it to all `.mw-ui-input` elements. Also adding rule to
remove proprietary IE 10-11 clear button. Bringing it on
par with OOjs UI.
Change-Id: Id375fdb86bf7ef3cfbb2f7e198d59be4947e4edb
rillke [Sat, 9 Apr 2016 23:49:52 +0000 (01:49 +0200)]
Do not validate relevant user name
- This makes Special:Log's behaviour consistent with other special
pages, e.g. Special:Contributions.
Change-Id: Ic0a9322d920d7514bacac1f29a1da4fe57cae854
jenkins-bot [Sat, 9 Apr 2016 20:28:15 +0000 (20:28 +0000)]
Merge "Add note that IP::isInRange() can return unexpected results for invalid args"
jenkins-bot [Sat, 9 Apr 2016 19:37:29 +0000 (19:37 +0000)]
Merge "Show absolute block expiry in user timezone on block logs"
umherirrender [Tue, 5 Apr 2016 17:11:00 +0000 (19:11 +0200)]
Show absolute block expiry in user timezone on block logs
For this add an user parameter to Language::translateBlockExpiry.
This allows the function to display the absolute block expiry in the
user's time zone. Use this when formatting block log entries.
This also avoids the use of $wgUser
Bug: T131241
Change-Id: If0a1d3c88bb4242a016eb9b2df115413de786149
jenkins-bot [Sat, 9 Apr 2016 18:02:04 +0000 (18:02 +0000)]
Merge "Switch Special:FileDuplicateSearch to OOUI"
jenkins-bot [Sat, 9 Apr 2016 17:50:51 +0000 (17:50 +0000)]
Merge "SpecialLog: Don't put assignment within another expression"
jenkins-bot [Sat, 9 Apr 2016 15:06:31 +0000 (15:06 +0000)]
Merge "Add possibility to filter for log_action in all core logs"
Ricordisamoa [Sat, 9 Apr 2016 04:37:33 +0000 (06:37 +0200)]
Make some TablePager methods actually protected
* getTableClass
* getNavClass
* getSortHeaderClass
Change-Id: I459ca456149635e3300c7ca7cfed4c1edc1c12b1
jenkins-bot [Fri, 8 Apr 2016 23:56:10 +0000 (23:56 +0000)]
Merge "Run generateLocalAutoload.php"
jenkins-bot [Fri, 8 Apr 2016 23:56:05 +0000 (23:56 +0000)]
Merge "Use pg_result_error, not pg_last_error, as the latter gives false negatives."
jenkins-bot [Fri, 8 Apr 2016 23:42:40 +0000 (23:42 +0000)]
Merge "Clean up after "Kill mbstring fallbacks""
Mark Holmquist [Thu, 7 Nov 2013 02:50:01 +0000 (18:50 -0800)]
Add preference for watching uploaded files
Adds a preference in the Watchlist section for watching uploaded files
for an account. Also works from API-based upload methods, so
UploadWizard and other tools should work fine.
Bug: T33313
Change-Id: If962e667de12b35904b2d1b2d9e99c26b588ec2a
Mark Holmquist [Fri, 4 Mar 2016 17:51:58 +0000 (11:51 -0600)]
Finish stash uploads with upload dialog
Adds a 'filekey' option to the upload dialog's booklet layout
so it's possible to complete a stashed upload with the dialog,
even if the dialog didn't stash the file.
Proof of concept gadget/userscript for testing purposes:
https://phabricator.wikimedia.org/P2783
Or use this ImageTweaks patch to test:
I8f8421697a6d44ec47b66496ad9ada548c4a7d0b
Change-Id: I2cdea08a29cd481eb7fe5cbd83b9e4b6941a6380
Translation updater bot [Fri, 8 Apr 2016 20:01:29 +0000 (22:01 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3bd0664b4ce71182be57e062204c0ae039fd8f84
jenkins-bot [Fri, 8 Apr 2016 18:12:54 +0000 (18:12 +0000)]
Merge "Change \\ to \ in phpdoc"
Gergő Tisza [Wed, 6 Apr 2016 22:22:33 +0000 (00:22 +0200)]
Change \\ to \ in phpdoc
Remove "\\" in namespacing. This is a Doxygen compatibility hack but
does not seem needed anymore, Doxygen reads namespaced class names
correctly, see e.g. https://doc.wikimedia.org/mediawiki-core/master/php/classMediaWiki_1_1Services_1_1ServiceContainer.html
PHP IDEs, on the other hand, were broken by the double backslash.
As an unrelated small doc fix, add parameter docs to PermissionError
constructor (parent has different arguments so the inherited
documentation is wrong).
Change-Id: I6da0f512b8c84f65fd20e90e4617108fe6a8fcd2
Kevin Israel [Fri, 8 Apr 2016 04:44:33 +0000 (00:44 -0400)]
Fix mbstring check in update.php
Maintenance::error() will not cause the script to exit unless the
$die argument, when cast as an integer, is greater than 0. Since
the default value is 0, specify a different one, as in the other
calls from within the same function.
Follows-up
943563062f0a6995.
Change-Id: I3af72b1cd87c63d7f57436866633e86c272e904f
jenkins-bot [Thu, 7 Apr 2016 20:39:39 +0000 (20:39 +0000)]
Merge "SkinTemplate.php: Add missing @param documentation to wrapHTML"
Translation updater bot [Thu, 7 Apr 2016 20:32:53 +0000 (22:32 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib3d0e6a16e61f0443aaa7e929d8bf66c45f5d4df
Fomafix [Thu, 7 Apr 2016 17:51:46 +0000 (17:51 +0000)]
SkinTemplate.php: Add missing @param documentation to wrapHTML
Follows-up to:
cab0275c7
Change-Id: Ie40229e92c0ce93628811ed7da4224ea7c15e72a
jenkins-bot [Thu, 7 Apr 2016 19:42:51 +0000 (19:42 +0000)]
Merge "Ignore DBPerformance warnings for ?action=purge for users with "purge""
Kevin Israel [Mon, 4 Apr 2016 03:27:50 +0000 (23:27 -0400)]
Run generateLocalAutoload.php
Change-Id: I618f831f5c33d0163b873dd0494cc37799450001
James D. Forrester [Thu, 7 Apr 2016 15:15:38 +0000 (08:15 -0700)]
Update OOjs UI to v0.16.5
Release notes:
https://git.wikimedia.org/blob/oojs%2Fui.git/v0.16.5/History.md
Change-Id: Ib5b0dc12259ac85ff1589c0e1507238f1089da3f
jenkins-bot [Thu, 7 Apr 2016 15:11:14 +0000 (15:11 +0000)]
Merge "Revert "Split ClassCollector class into own file""
Kevin Israel [Thu, 7 Apr 2016 10:01:45 +0000 (06:01 -0400)]
Clean up after "Kill mbstring fallbacks"
* Removed fallback code from Language, the associated data file
(Utf8Case.ser), and the code to generate that data file.
* Removed comment in LanguageFi that "mb_substr has a compatibility
function in GlobalFunctions.php".
* Removed check for mbstring in bench_utf8_title_check.php.
* In the tests for StringUtils::isUtf8():
* Removed separate test for the non-mbstring code path.
* Removed mentions of mbstring from function names and assertion
messages, since mb_check_encoding() is now always used.
* Also updated the comment in StringUtils::isUtf8() referring to
PHP 5.3, which is no longer supported in MediaWiki, to indicate
that the same issue also exists in old versions of HHVM. (If
we don't have to support 3.4 or older, then the function could
be deprecated and removed if desired.)
Follows-up
943563062f0a6995.
Change-Id: I55e5cd534b849c6ea06a7fadacbbf34a12d87ebe
jenkins-bot [Thu, 7 Apr 2016 08:47:03 +0000 (08:47 +0000)]
Merge "Allow to pass a rev id to a log entry without making it unpatrolled"
jenkins-bot [Thu, 7 Apr 2016 08:45:00 +0000 (08:45 +0000)]
Merge "Move action filter logic to LogPager"
jenkins-bot [Thu, 7 Apr 2016 06:56:51 +0000 (06:56 +0000)]
Merge "Support empty explicit plural forms in JavaScript"
Adrian Heine [Wed, 6 Apr 2016 13:22:29 +0000 (15:22 +0200)]
Support empty explicit plural forms in JavaScript
PHP supports them as well.
Change-Id: I7f7ed0a5b3e6ccbb904cde08d8818c2a665ac52e
jenkins-bot [Thu, 7 Apr 2016 00:37:36 +0000 (00:37 +0000)]
Merge "registration: Load extra autoload files before executing callbacks"
Max Semenik [Wed, 6 Apr 2016 23:30:41 +0000 (16:30 -0700)]
Explicitly require all the required PHP extensions
Change-Id: I2bca4ece0c49c3f4f802d3f8f543882ebd14d445
Florian [Wed, 6 Apr 2016 22:00:16 +0000 (00:00 +0200)]
registration: Load extra autoload files before executing callbacks
Callbacks should be able to safely assume that anything (or at least mostly)
defined in extension registration is already loaded and processed when
the callback itself is executed. To make sure, that this applies, callbacks
should be executed after all extra autoload paths are loaded.
Bug: T131978
Change-Id: I2c6624423957a8a00523b126fa7209d9c283aa9e
Max Semenik [Fri, 29 Jan 2016 19:42:44 +0000 (11:42 -0800)]
Kill mbstring fallbacks
In the age when we require PHP 5.5, pretending that mbstring emulation
is not slow and silly is silly.
Bug: T129435
Change-Id: Ic8235c9da9a926df63ec7388900c44eab454eebe
Max Semenik [Wed, 6 Apr 2016 21:59:01 +0000 (14:59 -0700)]
Unbreak tests
Bug: T131981
Change-Id: I1078b2a9f792f95fd451da4342b6441d6fd4d892
Translation updater bot [Wed, 6 Apr 2016 20:35:08 +0000 (22:35 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I1d8329f703a364fbe36a51994cdc0467cdd40387
addshore [Wed, 6 Apr 2016 11:21:24 +0000 (12:21 +0100)]
Fix phpdoc in StatsdAwareInterface
Change-Id: Ibb3cac402f2cbe723b79785f4d3bbcb9c0b10ebe
jenkins-bot [Wed, 6 Apr 2016 15:43:20 +0000 (15:43 +0000)]
Merge "Add a hook for collapsible content"
Smriti Singh [Thu, 10 Mar 2016 20:19:41 +0000 (01:49 +0530)]
User.php: Update 'setEmailWithConfirmation' for notification email
In order to minimise the chances of successful account cracking,
a notification email should be sent to the user on their previous
registered email address, informing them of the change in the
registered email address of their account.
Bug: T31856
Change-Id: Ib1ef76d7eb45ed0fa7ee0c2e7e39af21289367d2
jenkins-bot [Wed, 6 Apr 2016 11:48:06 +0000 (11:48 +0000)]
Merge "mediawiki.Title: Reuse local variable fragment"
Fomafix [Wed, 6 Apr 2016 04:27:17 +0000 (04:27 +0000)]
mediawiki.Title: Reuse local variable fragment
Change-Id: Ifc1153ef3246a387d2343e68e5b5f3837dd809cd
Arlo Breault [Fri, 5 Feb 2016 16:00:56 +0000 (08:00 -0800)]
Don't replace !! in elements
*
55313f4e almost got it right, but missed the str_replacing table
headings.
* Thankfully, this was doubly broken before that patch since the
StringUtils::explodeMarkup would have skipped the || which would
go on to be explode by table cell attribute parsing. The test case
provided would look like,
<table>
<tr>
<th class="">|">ha</div> ho
</th></tr></table>
Suffice it to say, noone is using this in production.
* Note that we can't just entity encode the ! since that would break
style attributes with !important.
* Also note, Parsoid already gets this right.
* Adds a StringUtils::replaceMarkup
Change-Id: Iab3ae4518fcb307b795d57eece420ba48af0a3bf
jenkins-bot [Wed, 6 Apr 2016 05:06:05 +0000 (05:06 +0000)]
Merge "mw.Upload.BookletLayout: Handle additional warnings/errors"
Bartosz Dziewoński [Tue, 5 Apr 2016 22:19:17 +0000 (00:19 +0200)]
Swap exif-pixelydimension and exif-pixelxdimension messages
Somehow we had width and height confused.
Bug: T107717
Change-Id: I06acb28d665302e77e6b2584910b4df001156e91
Arlo Breault [Tue, 5 Apr 2016 20:54:26 +0000 (13:54 -0700)]
Sync up with Parsoid parserTests.
This now aligns with Parsoid commit
d206ffe4026dcbce9ef27f1546d023a7027ea7e9
Change-Id: I9f7f0ddf87bf3ee14a1929599e72c5d837e15fbf
Bartosz Dziewoński [Tue, 5 Apr 2016 20:25:46 +0000 (22:25 +0200)]
mw.Upload.BookletLayout: Handle additional warnings/errors
Warnings:
* 'exists-normalized': Same handling as 'exists', the only difference
is exact match vs only matching after title normalization.
* 'was-deleted': Added new l10n message 'api-error-was-deleted',
based on 'filewasdeleted' but shorter/simpler.
Errors:
* 'protectedpage': Display 'protectedpagetext' message.
Bug: T131709
Change-Id: Ia9f65fc39d59018dc62b758f9a2ae98de7d187fe
jenkins-bot [Tue, 5 Apr 2016 20:22:52 +0000 (20:22 +0000)]
Merge "Update monolog to 1.18.2"
Translation updater bot [Tue, 5 Apr 2016 20:10:22 +0000 (22:10 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I17458dc07e3b940238dc2395e2fcc08833e303ab
Bartosz Dziewoński [Tue, 5 Apr 2016 20:09:40 +0000 (22:09 +0200)]
SpecialLog: Don't put assignment within another expression
Change-Id: I0a0cd9ee0647e8778d2e835cc02c571a83b3a8c2
Reedy [Sat, 2 Apr 2016 20:52:02 +0000 (21:52 +0100)]
Update monolog to 1.18.2
https://github.com/Seldaek/monolog/compare/1.17.2...1.18.2
Update KafkaHandlerTest.php
Depends-On: I32e9ebe0a10d97a1ccb0f4d605bd0ee9ba4e97f6
Change-Id: I35eedb6d95b68ebf90c00bb54469c9ff5731cdab
Kunal Mehta [Tue, 5 Apr 2016 19:49:55 +0000 (12:49 -0700)]
ImageListPager: Fix improper use of Title::newFromText().
The $defaultNamespace parameter to Title::newFromText() only applies if
a namespace prefix isn't included in the text. So if a username was
"Help:FooBar", the NS_USER prefix would not be applied.
Instead use Title::makeTitleSafe( NS_USER, ... ); which was designed for
this specific purpose.
Change-Id: Iafce73d352887947e61ae7c906ddf965e04fbf6f
Bartosz Dziewoński [Thu, 4 Feb 2016 01:13:24 +0000 (01:13 +0000)]
Preprocessor: Don't allow unclosed extension tags (matching until end of input)
(Previously done in
f51d0d9a819f8f1c181350ced2f015ce97985fcc and
reverted in
543f46e9c08e0ff8c5e8b4e917fcc045730ef1bc.)
I think it's saner to treat this as invalid syntax, and output the
mismatched tag code verbatim. The current behavior is particularly
annoying for <ref> tags, which often swallow everything afterwards.
This does not affect HTML tags, though. Assuming Tidy is enabled, they
are still auto-closed at the end of the page content. (For tags that
"shadow" a HTML tag name, this results in the tag being treated as a
HTML tag. This currently only affects <pre> tags: if unclosed, they
are still displayed as preformatted text, but without suppressing
wikitext formatting.)
It also does not affect <includeonly>, <noinclude> and <onlyinclude>
tags. Changing this behavior now would be too disruptive to existing
content, and is the reason why previous attempt was reverted. (They
are already special-cased enough that this isn't too weird, for example
mismatched closing tags are hidden.)
Related to T17712 and T58306. I think this brings the PHP parser closer
to Parsoid's interpretation.
It reduces performance somewhat in the worst case, though. Testing with
https://phabricator.wikimedia.org/
F3245989 (a 1 MB page starting with
3000 opening tags of 15 different types), parsing time rises from
~0.2 seconds to ~1.1 seconds on my setup. We go from O(N) to O(kN),
where N is bytes of input and k is the number of types of tags present
on the page. Maximum k shouldn't exceed 30 or so in reasonable setups
(depends on installed extensions, it's 20 on English Wikipedia).
Change-Id: Ide8b034e464eefb1b7c9e2a48ed06e21a7f8d434
C. Scott Ananian [Tue, 5 Apr 2016 17:55:26 +0000 (13:55 -0400)]
Improve comment to localizers in MessagesEn.php
Follow up to Ia670512e0cb375335873e7f9a08b638bbe039e45.
Bug: T116020
Change-Id: I8634585e52ce5339dbfcd5b19c5d1b6c9ef5687e
jenkins-bot [Tue, 5 Apr 2016 17:21:28 +0000 (17:21 +0000)]
Merge "Simplify by using mw.util.getUrl() instead of mw.util.wikiScript()"
Rohan [Fri, 11 Jul 2014 05:50:32 +0000 (11:20 +0530)]
Do not require login on Special:Confirmemail to confirm the email
The user doesn't need to be logged in to confirm his/her email.
Particle revert of I43ceaddb370d09784021b3fc2d5d1ff6616fef1f
Bug: T62434
Change-Id: Idf3f9827daaac87f5c57617f4e5d42ca9569839d
Fomafix [Tue, 5 Apr 2016 13:37:55 +0000 (13:37 +0000)]
Simplify by using mw.util.getUrl() instead of mw.util.wikiScript()
Change-Id: Ie10a5ee79846a4f1465fea7ce1b47da13b0787b7
MGChecker [Sat, 2 Apr 2016 21:15:31 +0000 (23:15 +0200)]
Add possibility to filter for log_action in all core logs
Adds possibility to filter all core logs with multiple log_actions, Log actions
newusers and create for the newusers log are treated as one, because newusers
is the predecessor of create and they describe the same actions.
Bug: T16334
Bug: T109267
Change-Id: I04a0ef1a6b4ea90c517a11045b6bd73c26b96863
Translation updater bot [Mon, 4 Apr 2016 19:53:49 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If37db4144db777658d3d2f3aa6bd140469a2547e
jenkins-bot [Mon, 4 Apr 2016 15:24:12 +0000 (15:24 +0000)]
Merge "Remove skin mode of Special:JavaScriptTest"
jenkins-bot [Mon, 4 Apr 2016 15:00:22 +0000 (15:00 +0000)]
Merge "mediawiki.util: Use wgScript in getUrl() when setting query string"
Yogesh K S [Sun, 28 Feb 2016 11:19:03 +0000 (16:49 +0530)]
Switch Special:FileDuplicateSearch to OOUI
Bug: T117745
Change-Id: I7541244cd06b6ea5c71e7f1e540474e8ae3740b5
utkarsh95 [Mon, 14 Mar 2016 11:52:00 +0000 (12:52 +0100)]
Convert Special:Redirect to OOUI
Removed unused message.
Bug: T117751
Change-Id: I70e04c8b5860e2b32081bdb510aca99fd5ee07f3
PleaseStand [Mon, 4 Apr 2016 03:26:24 +0000 (03:26 +0000)]
Revert "Split ClassCollector class into own file"
The AutoloadGenerator class is instantiated in the script
maintenance/generateLocalAutoload.php and its equivalents in
several extensions, none of which use MediaWiki's AutoLoader,
so you get a "Fatal error: Class 'ClassCollector' not found".
This reverts commit
a379bebd03099ee056a5ae7466f0699423064ede.
Change-Id: Ia6a7a1cb8a593ac86ecffdb690064e0b8ad68b47
Timo Tijhof [Sun, 3 Apr 2016 23:43:30 +0000 (00:43 +0100)]
mediawiki.util: Use wgScript in getUrl() when setting query string
This makes the behaviour more in line with Title::getLocalURL() in PHP.
* Only use wgArticlePath if there was a non-empty query string.
* Remove needless call to isEmptyObject. This is already done by $.params().
* Add test case "title with empty query string".
Change-Id: I414350a527eea3822ff2843c1c06a925f41a2c03