From 2c2dc593d25f652c04185e597b7f9de2c22c2e31 Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Sun, 24 Dec 2017 15:44:36 -0800 Subject: [PATCH] Add @covers tags API tests without them Change-Id: Ida0f954cb0a44719af3a3d0c6bda4587c9ca42b6 --- tests/phpunit/includes/api/ApiBaseTest.php | 4 ++++ tests/phpunit/includes/api/ApiOpenSearchTest.php | 3 +++ tests/phpunit/includes/api/ApiPageSetTest.php | 1 + tests/phpunit/includes/api/ApiQueryAllPagesTest.php | 2 ++ tests/phpunit/includes/api/ApiUploadTest.php | 2 ++ tests/phpunit/includes/api/ApiUsageExceptionTest.php | 3 +++ tests/phpunit/includes/api/ApiWatchTest.php | 2 ++ 7 files changed, 17 insertions(+) diff --git a/tests/phpunit/includes/api/ApiBaseTest.php b/tests/phpunit/includes/api/ApiBaseTest.php index ee0ad946bd..575f0c96d6 100644 --- a/tests/phpunit/includes/api/ApiBaseTest.php +++ b/tests/phpunit/includes/api/ApiBaseTest.php @@ -51,6 +51,7 @@ class ApiBaseTest extends ApiTestCase { * @param array $paramSettings * @param mixed $expected * @param string[] $warnings + * @covers ApiBase::getParameterFromSettings */ public function testGetParameterFromSettings( $input, $paramSettings, $expected, $warnings ) { $mock = new MockApi(); @@ -126,6 +127,9 @@ class ApiBaseTest extends ApiTestCase { ]; } + /** + * @covers ApiBase::errorArrayToStatus + */ public function testErrorArrayToStatus() { $mock = new MockApi(); diff --git a/tests/phpunit/includes/api/ApiOpenSearchTest.php b/tests/phpunit/includes/api/ApiOpenSearchTest.php index 23fa7bcb25..cc993d5df8 100644 --- a/tests/phpunit/includes/api/ApiOpenSearchTest.php +++ b/tests/phpunit/includes/api/ApiOpenSearchTest.php @@ -1,5 +1,8 @@ replaceSearchEngineConfig(); diff --git a/tests/phpunit/includes/api/ApiPageSetTest.php b/tests/phpunit/includes/api/ApiPageSetTest.php index 1aa0a133b9..10bdfa735c 100644 --- a/tests/phpunit/includes/api/ApiPageSetTest.php +++ b/tests/phpunit/includes/api/ApiPageSetTest.php @@ -4,6 +4,7 @@ * @group API * @group medium * @group Database + * @covers ApiPageSet */ class ApiPageSetTest extends ApiTestCase { public static function provideRedirectMergePolicy() { diff --git a/tests/phpunit/includes/api/ApiQueryAllPagesTest.php b/tests/phpunit/includes/api/ApiQueryAllPagesTest.php index 9f28aaf56e..b482c3189a 100644 --- a/tests/phpunit/includes/api/ApiQueryAllPagesTest.php +++ b/tests/phpunit/includes/api/ApiQueryAllPagesTest.php @@ -4,6 +4,8 @@ * @group API * @group Database * @group medium + * + * @covers ApiQueryAllPages */ class ApiQueryAllPagesTest extends ApiTestCase { diff --git a/tests/phpunit/includes/api/ApiUploadTest.php b/tests/phpunit/includes/api/ApiUploadTest.php index 159a0e36e4..6b604093e4 100644 --- a/tests/phpunit/includes/api/ApiUploadTest.php +++ b/tests/phpunit/includes/api/ApiUploadTest.php @@ -19,6 +19,8 @@ * @group Database * @group medium * @group Broken + * + * @covers ApiUpload */ class ApiUploadTest extends ApiTestCaseUpload { /** diff --git a/tests/phpunit/includes/api/ApiUsageExceptionTest.php b/tests/phpunit/includes/api/ApiUsageExceptionTest.php index f901cf2d1c..bb72021121 100644 --- a/tests/phpunit/includes/api/ApiUsageExceptionTest.php +++ b/tests/phpunit/includes/api/ApiUsageExceptionTest.php @@ -1,5 +1,8 @@