From 2b6cfa578c39158ffe3bd4ea26ffe2330605ee2a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Niklas=20Laxstr=C3=B6m?= Date: Fri, 18 Apr 2008 06:57:47 +0000 Subject: [PATCH] * Expiry handling is really sub-optimal here --- includes/ProtectionForm.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/includes/ProtectionForm.php b/includes/ProtectionForm.php index 6f57bc2547..0929461b9d 100644 --- a/includes/ProtectionForm.php +++ b/includes/ProtectionForm.php @@ -54,7 +54,8 @@ class ProtectionForm { } else if ( strlen($this->mTitle->mRestrictionsExpiry) == 0 ) { $this->mExpiry = ''; } else { - $this->mExpiry = wfTimestamp( TS_RFC2822, $this->mTitle->mRestrictionsExpiry ); + // FIXME: this format is not user friendly + $this->mExpiry = wfTimestamp( TS_ISO_8601, $this->mTitle->mRestrictionsExpiry ); } } @@ -170,6 +171,8 @@ class ProtectionForm { return false; } + // Fixme: non-qualified absolute times are not in users specified timezone + // and there isn't notice about it in the ui $expiry = wfTimestamp( TS_MW, $expiry ); if ( $expiry < wfTimestampNow() ) { -- 2.20.1