From 1cb1abe773ccd5bcbfafcb48d64908b36c721f67 Mon Sep 17 00:00:00 2001 From: Antoine Musso Date: Tue, 7 Feb 2012 17:56:32 +0000 Subject: [PATCH] add up comment for FileCache rewrite (r98698) --- includes/DefaultSettings.php | 2 ++ includes/cache/FileCacheBase.php | 5 ++++- includes/cache/HTMLFileCache.php | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index 0f657e58c8..b6908966d4 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -1697,6 +1697,8 @@ $wgStyleVersion = '303'; * This will cache static pages for non-logged-in users to reduce * database traffic on public sites. * Must set $wgShowIPinHeader = false + * ResourceLoader requests to default language and skins are cached + * as well as single module requests. */ $wgUseFileCache = false; diff --git a/includes/cache/FileCacheBase.php b/includes/cache/FileCacheBase.php index d3558184b8..00fe995793 100644 --- a/includes/cache/FileCacheBase.php +++ b/includes/cache/FileCacheBase.php @@ -169,7 +169,10 @@ abstract class FileCacheBase { } /** - * Get the cache type subdirectory (with trailing slash) or the empty string + * Get the cache type subdirectory (with trailing slash) + * An extending class could use that method to alter the type -> directory + * mapping. @see HTMLFileCache::typeSubdirectory() for an example. + * * @return string */ protected function typeSubdirectory() { diff --git a/includes/cache/HTMLFileCache.php b/includes/cache/HTMLFileCache.php index 5e9d8127b3..92130f693a 100644 --- a/includes/cache/HTMLFileCache.php +++ b/includes/cache/HTMLFileCache.php @@ -45,6 +45,8 @@ class HTMLFileCache extends FileCacheBase { /** * Get the cache type subdirectory (with the trailing slash) or the empty string + * Alter the type -> directory mapping to put action=view cache at the root. + * * @return string */ protected function typeSubdirectory() { -- 2.20.1